[Merged by Bors] - Add Deployment controller for managed connectors #1499
Conversation
simlay
changed the title
crates/fluvio-sc/src/k8/controllers/managed_connector_deployment.rs
Outdated
Show resolved
Hide resolved
crates/fluvio-sc/src/k8/controllers/managed_connector_deployment.rs
Outdated
Show resolved
Hide resolved
crates/fluvio-sc/src/k8/controllers/managed_connector_deployment.rs
Outdated
Show resolved
Hide resolved
crates/fluvio-sc/src/k8/controllers/managed_connector_deployment.rs
Outdated
Show resolved
Hide resolved
| fn convert_from_k8( | ||
| k8_obj: K8Obj<Self::K8Spec>, | ||
| ) -> Result<MetadataStoreObject<Self, K8MetaItem>, K8ConvertError<Self::K8Spec>> { | ||
| default_convert_from_k8(k8_obj) |
There was a problem hiding this comment.
if this is custom spec that derives from DeploymentSpec, shouldn't this filter only deployment spec? This will map all deployment as ManagedConnector
There was a problem hiding this comment.
Nick and I played around with making it a more generic deployment spec but decided it was more work than it was work so we went with a similar pattern to the SpgStatefulSetController.
There was a problem hiding this comment.
How does it know to separate from SC deployment? For example, if SC gets restart, this will trigger ManagedConnector Controller and generate connector deployment
| fn convert_from_k8( | ||
| k8_obj: K8Obj<Self::K8Spec>, | ||
| ) -> Result<MetadataStoreObject<Self, K8MetaItem>, K8ConvertError<Self::K8Spec>> { | ||
| default_convert_from_k8(k8_obj) |
There was a problem hiding this comment.
How does it know to separate from SC deployment? For example, if SC gets restart, this will trigger ManagedConnector Controller and generate connector deployment
crates/fluvio-sc/src/k8/objects/managed_connector_deployment.rs
Outdated
Show resolved
Hide resolved
|
and need to be rebased |
|
bors r+ |
Closes #1648. Co-authored-by: Nick Cardin <nick@cardin.email>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Closes #1648.