Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mappings for macOS system headers #1633

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

petere
Copy link

@petere petere commented Sep 29, 2024

I have accumulated a bunch of mappings for macOS system headers. I wonder if there is interest in keeping this in IWYU upstream. These are similar in spirit to for example gcc.libc.imp. Right now, these are just manually maintained, I haven't done any scripted analysis like the comments in some of the other mapping files suggest. If there is general interest, I can do that too. Let me know, please.

@kimgr
Copy link
Contributor

kimgr commented Sep 29, 2024

@petere Thanks! Yes, this would help improve the macOS experience, and I think it's a good idea to start with the libc as you've done. There's been a bunch of discussions recently on manual mappings, and I'm pretty firmly convinced that shipping generators for mappings is the way to go (so that people can easily refresh mappings for their local install of IWYU using the same tools we use upstream).

Mapping generators so far are in https://github.com/include-what-you-use/include-what-you-use/tree/master/mapgen, and I'd prefer to keep them all python for portability reasons. See also this PR for a recent attempt to do the same for GNU libstdc++.

I'm reluctant to bring in the macOS mappings as listed in this PR, because I suspect they only cover a practical subset, and will see a lot of churn before they reach more general usefulness. But maybe I'm overthinking?

Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants