-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix analysis over umbrella apps #179
Fix analysis over umbrella apps #179
Conversation
I like it… let's see if the windows-ci starts working at some point. |
@elbrujohalcon, I moved the tasks from the issue here (check the description) so there's visibility. I still want to had tests lest we end up in the same situation. |
Includes a small patch to run the tests on Windows Co-authored-by: Brujo Benavides <elbrujohalcon@gmail.com>
@elbrujohalcon: pushed some tests. I'm not sure we need something more elaborate. It walks an expected (and advertised, in |
I segregated the Windows CI thing to an Issue, lest we're blocked because of it. I'd wrongly assumed stuff was already working and would have only to deal with the container stuff, but it seems not. |
@joaohf, do you want to try these changes out to see if they fix your specific issue? |
@paulo-ferraz-oliveira sure, I'll try today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how this looks.
I'll wait for @joaohf to confirm that it works and then I'll merge. |
Alright, the fix works for me. Really good. Thank you guys. |
@joaohf, is it acceptable to rely on |
Sure, don't worry. I can rely on master until there. |
Closes #178.
Note: this includes a small patch to run the tests on Windows.