Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix analysis over umbrella apps #179

Merged
merged 3 commits into from
Mar 10, 2021
Merged

Fix analysis over umbrella apps #179

merged 3 commits into from
Mar 10, 2021

Conversation

paulo-ferraz-oliveira
Copy link
Collaborator

@paulo-ferraz-oliveira paulo-ferraz-oliveira commented Mar 10, 2021

Closes #178.

  • make sure tests are passing in Windows
  • make sure to add tests for updated functionality (namely we should test folder structure as per umbrella apps)

Note: this includes a small patch to run the tests on Windows.

src/elvis_file.erl Outdated Show resolved Hide resolved
@elbrujohalcon
Copy link
Member

I like it… let's see if the windows-ci starts working at some point.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

@elbrujohalcon, I moved the tasks from the issue here (check the description) so there's visibility. I still want to had tests lest we end up in the same situation.

paulo-ferraz-oliveira and others added 2 commits March 10, 2021 12:03
Includes a small patch to run the tests on Windows

Co-authored-by: Brujo Benavides <elbrujohalcon@gmail.com>
@paulo-ferraz-oliveira
Copy link
Collaborator Author

@elbrujohalcon: pushed some tests. I'm not sure we need something more elaborate. It walks an expected (and advertised, in rebar3_lint folder structure) using regex.
Should we probably throw in a ignore test?

@paulo-ferraz-oliveira
Copy link
Collaborator Author

I segregated the Windows CI thing to an Issue, lest we're blocked because of it. I'd wrongly assumed stuff was already working and would have only to deal with the container stuff, but it seems not.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

@joaohf, do you want to try these changes out to see if they fix your specific issue?

@joaohf
Copy link

joaohf commented Mar 10, 2021

@paulo-ferraz-oliveira sure, I'll try today.

Copy link
Member

@elbrujohalcon elbrujohalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how this looks.

@elbrujohalcon
Copy link
Member

I'll wait for @joaohf to confirm that it works and then I'll merge.

@joaohf
Copy link

joaohf commented Mar 10, 2021

Alright, the fix works for me. Really good. Thank you guys.

@elbrujohalcon elbrujohalcon merged commit 97f8e02 into inaka:master Mar 10, 2021
@paulo-ferraz-oliveira
Copy link
Collaborator Author

@joaohf, is it acceptable to rely on master for the time being, before we cut a release? I don't expect this to break for anyone relying on master, but the next few days will tell 😄

@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the fix/analysis-over-umbrella-apps branch March 10, 2021 15:32
@joaohf
Copy link

joaohf commented Mar 10, 2021

Sure, don't worry. I can rely on master until there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analysis not working over umbrella apps
3 participants