Issue warnings on empty folders #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps keep a trimmed down elvis.config Example output: Warning: Searching for files in ["test/examples/2"] yielded none. Update your configuration.
|
I don't think we have tests in place for any of these things (I mean… just with a quick grep… I couldn't find any test for error printing either). Maybe we test these things indirectly from I'm fine if you don't want to spend more time trying too hard to test this. If you're already done with this, I'll go ahead and merge it as-is. |
|
I'd appreciate it if you'd at least try it out and tell me if the UX is good. Other than that, I'm OK for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #146.
Since this is a warning, not a hard error, and there's no output (except for the visible message), I couldn't think of a nice enough test. Suggestions?
Note: I add the possibility to write warnings, in magenta, since I want to distinguish these from errors.