Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a session is shut down, should this clear the xrCompatible flag? #607

Closed
asajeffrey opened this issue Apr 24, 2019 · 3 comments · Fixed by #705
Closed

When a session is shut down, should this clear the xrCompatible flag? #607

asajeffrey opened this issue Apr 24, 2019 · 3 comments · Fixed by #705
Assignees
@Manishearth
Labels
fixed by pending PR A PR that is in review will resolve this issue. help wanted This is a good issue for anyone to pick up and work on filing a PR for.
Milestone
June 2019

Comments

@asajeffrey
Copy link

Currently, ending an XRSession (https://immersive-web.github.io/webxr/#shut-down-the-session) doesn't clear the xrCompatible flag of any WebGL rendering context. As a result, ending a session, then beginning a new session on a device with a different GPU, results in the xrCompatible flag being true, even though the context is using an incompatible GPU.
@NellWaliczek NellWaliczek added the help wanted This is a good issue for anyone to pick up and work on filing a PR for. label May 28, 2019
@NellWaliczek NellWaliczek modified the milestones: June 2019, July 2019 May 28, 2019
@Manishearth Manishearth self-assigned this Jun 14, 2019
@Manishearth Manishearth added the fixed by pending PR A PR that is in review will resolve this issue. label Jun 14, 2019
@Manishearth Manishearth mentioned this issue Jun 14, 2019
Merged
@Manishearth
Copy link
Contributor

#705

@toji
Copy link
Member

toji commented Jun 14, 2019

Sorry for the confusion, but I don't think this is a concern. If a session shuts down and another is created with the same XR device we definitely want to keep the compatibility bit valid. The only time that it should become invalid is if the underlying device that new sessions would be created against changes, and we already have it specified that making that change does invalidate the compatibility bits. See http://localhost:8080/webxr/#select-an-xr-device

@NellWaliczek: Is there something else about this issue that I'm not remembering that we wanted to address? Feels like we should have caught this during triage, but maybe we did and there was an aspect of it that we still wanted to look into?

@asajeffrey
Copy link
Author

Ah, so the flag isn't cleared when the session is shut down, but it is cleared when a new session is begun. That works.

@toji toji closed this as completed in #705 Jun 17, 2019
@toji toji modified the milestones: July 2019, June 2019 Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Manishearth Manishearth

Labels
fixed by pending PR A PR that is in review will resolve this issue. help wanted This is a good issue for anyone to pick up and work on filing a PR for.
Projects
None yet
Milestone
June 2019
Development

Successfully merging a pull request may close this issue.

Don't check XR compat flag for inline sessions Manishearth/webxr
5 participants
@asajeffrey @cwilso @toji @Manishearth @NellWaliczek