bug fix

imanjra · Jul 12, 2022 · 45b9d61 · 45b9d61
1 parent 3a9cf87
commit 45b9d61
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/fiftyone/core/aggregations.py b/fiftyone/core/aggregations.py
@@ -1458,7 +1458,7 @@ def to_mongo(self, sample_collection):
         # Note that we don't need to explicitly handle empty `values` here
         # because the `group` stage only outputs a document if there's at least
         # one value to compute on!
-        array = F("values").sort()
+        array = F("values").sort(numeric=True)
         idx = ((F() * array.length()).ceil() - 1).max(0)
         quantile_expr = array.let_in(E(self._quantiles).map(array[idx]))
 

diff --git a/fiftyone/core/expressions.py b/fiftyone/core/expressions.py
@@ -2584,7 +2584,7 @@ def reverse(self):
         """
         return ViewExpression({"$reverseArray": self})
 
-    def sort(self, key=None, reverse=False):
+    def sort(self, key=None, numeric=False, reverse=False):
         """Sorts this expression, which must resolve to an array.
 
         If no ``key`` is provided, this array must contain elements whose
@@ -2637,13 +2637,19 @@ def sort(self, key=None, reverse=False):
 
         Args:
             key (None): an optional field or ``embedded.field.name`` to sort by
+            numeric (False): whether the array contains numeric values. By
+                default, the values will be sorted alphabetically by their
+                string representations
             reverse (False): whether to sort in descending order
 
         Returns:
             a :class:`ViewExpression`
         """
         if key is not None:
+            # @todo this implicitly assumes `key` is numeric
             comp = "(a, b) => a.{key} - b.{key}".format(key=key)
+        elif numeric:
+            comp = "(a, b) => a - b"
         else:
             comp = ""