A side issue…

Looking at the IINA Default bindings with Display raw values enabled I see that the IINA bindings avoid using Shift for letter keys and instead use a capital letter.

But this is not entirely true. If this is the convention shouldn't for example Shift+Meta+v be Meta+V?

Great to get this completed. I've been trying to make sure all the issues planned for the bug fix release are ready for when the other developers get a chance to review, merge and prepare a release. Hopefully that will happen soon so we can move on to the release that is focused on adding features.

By the way, GitHub follows the 50/72 commit message rule. An explanation of this rule can be found in this comment on a GitHub Desktop issue requesting an enhancement to help developers adhere to the rule. That comment also contains some links including How to Write a Git Commit Message which goes into more detail.

The 50 character limit is hard to adhere to. You will find commits from me that exceed that limit, but I always adhere to the 72 character limit.

A side issue…

Looking at the IINA Default bindings with Display raw values enabled I see that the IINA bindings avoid using Shift for letter keys and instead use a capital letter.

But this is not entirely true. If this is the convention shouldn't for example Shift+Meta+v be Meta+V?

It should. But I thought it best not to push for too many changes. The least I can do is use the normalized form for any lines that already need to be changed.

By the way, GitHub follows the 50/72 commit message rule. An explanation of this rule can be found in desktop/desktop#2055 (comment) on a GitHub Desktop issue requesting an enhancement to help developers adhere to the rule. That comment also contains some links including How to Write a Git Commit Message which goes into more detail.

The 50 character limit is hard to adhere to. You will find commits from me that exceed that limit, but I always adhere to the 72 character limit.

Eh, yeah ;) It is hard. When the commit has a complex change it feels like working on a crossword puzzle. Stealing precious cognitive load from more important tasks like coming up with function names. It would be great if there was something like semantic commit messages but with a larger vocabulary. But yeah I will try to tidy up my messages.

It should. But I thought it best not to push for too many changes. The least I can do is use the normalized form for any lines that already need to be changed.

I thought it might be something like that. Makes sense. I just wanted to understand the reasoning.