optimize block remove animation

igrep · Feb 17, 2024 · 7c5f644 · 7c5f644
1 parent b1cb998
commit 7c5f644
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/game/blocks.ts b/src/game/blocks.ts
@@ -1,5 +1,7 @@
 import { getBlockElements } from "./getBlockElements"
 
+// A block is "remained" until the ball hits it,
+// and then it's "removed" when remove animation is done.
 export type Block = {
   uuid: string
   element: Element
@@ -10,6 +12,7 @@ export type Block = {
     right: number
   }
   remain: boolean
+  removed: boolean
 }
 
 export function getBlocks(): Block[] {
@@ -23,7 +26,8 @@ function convertElementToBlock(element: Element): Block {
     uuid: Math.random().toString(36).slice(-8),
     element,
     rect: getRectOfBlock(element),
-    remain: true
+    remain: true,
+    removed: false
   }
 }
 

diff --git a/src/game/updateBlocks.ts b/src/game/updateBlocks.ts
@@ -21,7 +21,7 @@ export function startBlockAndScoreUpdate(
     for (let i = 0; i < blocks.length; i++) {
       const block = blocks[i]
       if (!block.remain) {
-        removeBlockAndUpdateBlocksPosition(block, blocks)
+        !block.removed && removeBlockAndUpdateBlocksPosition(block, blocks)
         scoreboard && score++
       }
     }
@@ -56,6 +56,8 @@ function removeBlockAndUpdateBlocksPosition(block: Block, blocks: Block[]) {
 }
 
 function removeBlock(block: Block) {
+  block.removed = true
+
   const element = block.element
 
   if (isFrameElement(element)) {