add type assertion

igrep · Mar 4, 2024 · 3328753 · 3328753
1 parent e3791d4
commit 3328753
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 13 deletions.
diff --git a/src/game/animation/updateBlocks.ts b/src/game/animation/updateBlocks.ts
@@ -79,13 +79,15 @@ function removeBlock(block: Block) {
   Array.from(block.element.children).forEach((childEl) => {
     originalVisibilities.push(getComputedStyleWithCache(childEl).visibility)
   })
-  Object.assign(block.element.style, {
-    visibility: "hidden"
-  })
-  Array.from(block.element.children).forEach((childEl, i) => {
-    Object.assign(childEl.style, {
-      visibility: originalVisibilities[i]
+  ;(block.element as HTMLElement).style && // TODO: remove type assertion
+    Object.assign((block.element as HTMLElement).style, {
+      visibility: "hidden"
     })
+  Array.from(block.element.children).forEach((childEl, i) => {
+    ;(childEl as HTMLElement).style && // TODO: remove type assertion
+      Object.assign((childEl as HTMLElement).style, {
+        visibility: originalVisibilities[i]
+      })
   })
 }
 

diff --git a/src/game/debug.ts b/src/game/debug.ts
@@ -23,13 +23,15 @@ export function visualizeBlocks(blocks: Block[]) {
   for (let i = 0; i < blocks.length; i++) {
     const blockElement = blocks[i].element
     if (blocks[i].remain) {
-      Object.assign(blockElement.style, {
-        border: "0.1px solid red"
-      })
+      ;(blockElement as HTMLElement).style && // TODO: remove type assertion
+        Object.assign((blockElement as HTMLElement).style, {
+          border: "0.1px solid red"
+        })
     } else {
-      Object.assign(blockElement.style, {
-        border: "none"
-      })
+      ;(blockElement as HTMLElement).style && // TODO: remove type assertion
+        Object.assign((blockElement as HTMLElement).style, {
+          border: "none"
+        })
     }
   }
 }

diff --git a/src/game/object/blocks.ts b/src/game/object/blocks.ts
@@ -6,7 +6,7 @@ import { getBlockElements } from "./getBlockElements"
 // and then it's "removed" when remove animation is done.
 export type Block = {
   uuid: string
-  element: Element
+  element: Element // this includes not only HTMLElement but also others like SVGElement.
   rect: {
     top: number
     bottom: number