omit properties of DOMRect from getComputedWithCache

igrep · Feb 16, 2024 · 2384c33 · 2384c33
1 parent 2e9f87b
commit 2384c33
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/game/getComputedStyleWithCache.ts b/src/game/getComputedStyleWithCache.ts
@@ -1,9 +1,13 @@
 // getComputedStyle() is expensive, so we should cache the result.
-// We can assume that the style of an element doesn't change, because the page is frozen.
+// We can assume that the style of an element doesn't change, except for DOMRect-related,
+// because the page is frozen.
 const styleCache = new Map<Element, CSSStyleDeclaration>()
 export function getComputedStyleWithCache(
   element: Element
-): CSSStyleDeclaration {
+): Omit<
+  CSSStyleDeclaration,
+  keyof ReturnType<typeof Element.prototype.getBoundingClientRect>
+> {
   const cache = styleCache.get(element)
   if (cache) {
     return cache