Add ESM Support. #36
Open
Add ESM Support. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsejcksn
suggested changes
Jul 13, 2020
|
@iarna any ETA on this getting merged? |
|
Related: trying to use with vite gives |
|
I use vite, got error: Uncaught ReferenceError: global is not defined. ESM support would be nice.So I made an ESM verion,works well with vite |
|
use iarna-toml-esm |
|
Probably makes sense to use https://github.com/squirrelchat/smol-toml |
Yes, I find it in TOML offical repo. But iarna-toml repo is the first search result when I search "TOML" key word by github search bar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds full ESM support for all viable versions (Node 12-14 and above), while also maintaining full CommonJS support in every version. This is achieved through a very simple wrapper file that re-exports CommonJS code as ESM, but only when an
importstatement is used instead ofrequire().Node 12-13 have highly experimental ESM support that may require a flag and/or a subpath (
import "@iarna/toml/esm") in order to function. If you don't wish to support this, or if you find the/esmsubpath messy, you could easily remove the"./esm": "./toml-esm.mjs"line from thepackage.jsonfile, while still maintaining full ESM support in Node 14 and all later versions.I was unsure if any documentation is necessary for this change, but I would think at most a small note would be enough. Feel free to let me know if (and ideally what kind of) documentation is necessary.
Fixes #32