Fix rename columns transformer

iamoat · Nov 5, 2018 · 4869a79 · 4869a79
1 parent 5ec7c9c
commit 4869a79
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 16 deletions.
diff --git a/src/Transformers/RenameColumns.php b/src/Transformers/RenameColumns.php
@@ -2,6 +2,8 @@
 
 namespace Marquine\Etl\Transformers;
 
+use Marquine\Etl\Row;
+
 class RenameColumns extends Transformer
 {
     /**
@@ -21,19 +23,17 @@ class RenameColumns extends Transformer
     ];
 
     /**
-     * Get the transformer handler.
+     * Transform the given row.
      *
-     * @return callable
+     * @param  \Marquine\Etl\Row  $row
+     * @return void
      */
-    public function transform()
+    public function transform(Row $row)
     {
-        return function ($row) {
-            foreach ($this->columns as $old => $new) {
-                $row[$new] = $row[$old];
-                unset($row[$old]);
-            }
-
-            return $row;
-        };
+        foreach ($this->columns as $old => $new) {
+            $value = $row->get($old);
+            $row->remove($old);
+            $row->set($new, $value);
+        }
     }
 }
diff --git a/tests/Transformers/RenameColumnsTest.php b/tests/Transformers/RenameColumnsTest.php
@@ -3,6 +3,7 @@
 namespace Tests\Transformers;
 
 use Tests\TestCase;
+use Marquine\Etl\Row;
 use Marquine\Etl\Transformers\RenameColumns;
 
 class RenameColumnsTest extends TestCase
@@ -11,19 +12,21 @@ class RenameColumnsTest extends TestCase
     public function rename_column()
     {
         $data = [
-            ['id' => '1', 'name' => 'John Doe', 'email_address' => 'johndoe@email.com'],
-            ['id' => '2', 'name' => 'Jane Doe', 'email_address' => 'janedoe@email.com'],
+            new Row(['id' => '1', 'name' => 'John Doe', 'email_address' => 'johndoe@email.com']),
+            new Row(['id' => '2', 'name' => 'Jane Doe', 'email_address' => 'janedoe@email.com']),
         ];
 
         $expected = [
-            ['id' => '1', 'name' => 'John Doe', 'email' => 'johndoe@email.com'],
-            ['id' => '2', 'name' => 'Jane Doe', 'email' => 'janedoe@email.com'],
+            new Row(['id' => '1', 'name' => 'John Doe', 'email' => 'johndoe@email.com']),
+            new Row(['id' => '2', 'name' => 'Jane Doe', 'email' => 'janedoe@email.com']),
         ];
 
         $transformer = new RenameColumns;
 
         $transformer->options(['columns' => ['email_address' => 'email']]);
 
-        $this->assertEquals($expected, array_map($transformer->transform(), $data));
+        array_map([$transformer, 'transform'], $data);
+
+        $this->assertEquals($expected, $data);
     }
 }