master: make loop around optional when cycling #8926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
reviewed
Jan 1, 2025
lonyelon
force-pushed
the
optional-cycling-test
branch
from
5f93dfe to
f716ee0
Compare
|
Hello vaxry, Would it be better to add a new layout command named |
lonyelon
force-pushed
the
optional-cycling-test
branch
from
f716ee0 to
2c2bb81
Compare
|
no, param is better imo |
|
Ok so we can leave it like this. |
vaxerski
previously approved these changes
Jan 3, 2025
|
Added in hyprwm/hyprland-wiki#926! |
lonyelon
force-pushed
the
optional-cycling-test
branch
from
2c2bb81 to
aa1c154
Compare
|
clang style issues fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Implement the option to not loop around when cycling windows in the master layout (i.e. going from master to the last slave or vice-versa), replicating this layout's behavior in DWL.
No default behavior was modified, and the option
noLoopAroundoption was added tocyclenext,cycleprev,swapnextandswapprev. This ensures no current setups are broken.Example usage:
Is it ready for merging, or does it need work?
I think it is, I tested it and it works, but I am new in this codebase so some important test may be missing.