Fix crash when when swallowed window is closed #5554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
reviewed
Apr 11, 2024
Bartkk0
force-pushed
the
swallow_crash_fix
branch
from
a2daaa3 to
9a92787
Compare
vaxerski
reviewed
Apr 11, 2024
| @@ -687,7 +687,7 @@ void Events::listener_unmapWindow(void* owner, void* data) { | |||
| g_pHyprOpenGL->makeWindowSnapshot(PWINDOW); | |||
|
|
|||
| // swallowing | |||
| if (PWINDOW->m_pSwallowed && g_pCompositor->windowExists(PWINDOW->m_pSwallowed)) { | |||
| if (PWINDOW->m_pSwallowed && g_pCompositor->windowExists(PWINDOW->m_pSwallowed) && !PWINDOW->m_pSwallowed->m_bReadyToDelete) { | |||
There was a problem hiding this comment.
check should be for m_bIsMapped
|
should be fixed by #5548 I think |
|
Yeah, compiled the PR and Hyprland no longer crashes, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Fixes a crash when a swallowed window is closed. From what I've discovered it happens randomly depending on which window is closed first, at least it appears to be the cause.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
I don't know if it's the right way to fix this crash, but it works.
Is it ready for merging, or does it need work?
Ready