Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAB-17158 ignore util test using build tag #325

Merged
merged 1 commit into from
Nov 29, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions integration/ledger/ledger_generate_test.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// +build generate

/*
Copyright IBM Corp All Rights Reserved.

Expand All @@ -16,7 +18,7 @@ import (
)

// This test generate sample ledger data that can be used to verify rebuild ledger function and upgrade function (in a future release).
// It is skipped in general. To generate sample ledger data, comment out the line `xxx` and run this test in isolation.
// It is skipped in general. To generate sample ledger data, use build tag 'generate' and run this test in isolation.
// It does not delete the network directory so that you can copy the generated data to a different directory for unit tests.
// At the end of test, it prints `setup.testDir is <directory>`. Copy the network data under <directory> to
// the unit test directory for rebuild tests as needed.
Expand Down Expand Up @@ -77,12 +79,10 @@ var _ = Describe("sample ledger generation", func() {
setup.terminateAllProcess()
setup.network.Cleanup()
// do not delete testDir and log it so that we can copy the test data to unit tests for verification purpose
fmt.Printf("The test dir is %s. Use peers/org2.peer0/filesystem/ledgersData as the sample ledger for kvledger rebuild tests\n", setup.testDir)
fmt.Fprintf(GinkgoWriter, "The test dir is %s. Use peers/org2.peer0/filesystem/ledgersData as the sample ledger for kvledger rebuild tests\n", setup.testDir)
})

It("creates marbles", func() {
Skip("Uncomment to generate sample ledger in v2.0 with new lifecycle chaincode deployment")

org2peer0 := setup.network.Peer("org2", "peer0")
height := helper.getLedgerHeight(org2peer0)

Expand Down