This repository has been archived by the owner on Jan 26, 2023. It is now read-only.
Fix failing exportCsv test from promise rejection #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In tested logic, createObjectURL() gets called but doesn't exist in JSDOM mocks. Stub it out for this test, also simplify the mock that feeds the value. Also make the downloadBlob which directly deals in values there more exact.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tested logic,
createObjectURL()gets called but doesn't exist inJSDOMmocks. Stub it out for this test, also simplify the mock that feeds the value. Also make thedownloadBlobwhich directly deals in values there more exact.Having a shared or global
createObjectURL()test mock might be neater, it's replaced in a few other places, and swapping out globals inside of a test can be a little suspect.To get this to install/build with node 16 I also needed to replace
node-sassbut dependency updates are a bigger thing so leaving alone for now.