Replies: 5 comments 6 replies
-
|
FWIW I have a registry project with the kind of injection you describe. It’s critical for a larger effort I have in mind. I’m investigating re-homing my stuff atop svcs… going through a gap analysis now to see which of my darlings (features) to kill. |
Beta Was this translation helpful? Give feedback.
-
|
To my understanding we have a couple of corner cases here:
One benefit I see for factory builder over registry method is ability to customize factory: fctr = make_factory(Srvc)
def factory(svcs_container):
with fctr(svcs_container) as instance:
yield instance
registry.register(Srvc, factory)In case our service has it's own life circle an supposed to be used as context manager. |
Beta Was this translation helpful? Give feedback.
-
Could both be avoided by making it a class… say…
I don't quite follow here. It kinda sounds like feature-creep? I'm trying to take advantage of type annotations here and not automate away everything to the point of svcs becoming an opaque blog like most DI frameworks. 😅 |
Beta Was this translation helpful? Give feedback.
-
|
@hynek let me put it this way 🌴 🍸 |
Beta Was this translation helpful? Give feedback.
-
|
@hynek I would like to contribute this feature to the project. Any thoughts on constraints / design decisions mentioned above? |
Beta Was this translation helpful? Give feedback.
-
|
Cool!! I've been meaning to attack the bigger issues in svcs forever but I keep getting pulled into my Big Two (attrs, structlog) all the time. :( |
Beta Was this translation helpful? Give feedback.
-
|
I'll be hiking in the mountains for next two weeks. Planning to make some progress on this feature before new year. |
Beta Was this translation helpful? Give feedback.
-
|
looong hike @proofit404! 😇 |
Beta Was this translation helpful? Give feedback.
-
|
I had an overlap with team-building event, and family visit for a new year. Actually, today is my first working day since November. |
Beta Was this translation helpful? Give feedback.
-
|
Funny enough, I loaded this stuff (and my thing) back into my brain yesterday. |
Beta Was this translation helpful? Give feedback.
-
|
@proofit404 If you do wind up working on it, I have code/tests for sniffing that I could look at in helping. |
Beta Was this translation helpful? Give feedback.
-
As it just came up in #86, I use a pattern similar to this all the time:
svcs will always be non-magical by default, but I guess nothing speaks against adding a helper that makes the lambda superfluous by looking at the type hints of the factory and calling
svcs_container.(a)geton the required types automatically:Since this would only be a helper, it wouldn't also have the pressure to implement all edge cases because the escape hatch of just writing your own lambda is always there.
Beta Was this translation helpful? Give feedback.
All reactions