Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate HTML preview links on PRs #11

Open
micahhausler opened this issue Jul 19, 2021 · 0 comments
Open

Generate HTML preview links on PRs #11

micahhausler opened this issue Jul 19, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@micahhausler
Copy link
Contributor

It wouldn't be a ton of work to do a git diff --name-only $GITHUB_HEAD_REF $GITHUB_BASE_REF | grep ThreatModel.html and generate a list of https://htmlpreview.github.io/ links when new examples are added, and it'd be helpful for reviewers to just click the links instead of scrounging around to put them together

example link from #9: https://htmlpreview.github.io/?https://github.com/hyakuhei/fluentm/blob/d6595139c6f6e164b30634c1165668386ff366a7/examples/tinkerbell/ThreatModel.html

@hyakuhei hyakuhei added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants