More Improvements: #3
Conversation
mrbrutti
commented
Apr 16, 2021
mrbrutti
commented
- Migrating renderer into a class
- Renderer support of with statement to improve overall flow to build graphs.
- style is imported by default - createEdge -> connectTo - connectTo returns endNode to allow method concatenation.
- Migrating renderer into a class - Renderer support of with statement to improve overall flow to build graphs.
| if __name__ == "__main__": | ||
| root = Node(label="Reality") | ||
| goal = Node(label="Attacker gets data from bucket") | ||
| with Renderer(root = "Reality", goal= "Attacker gets data from bucket") as graph: |
There was a problem hiding this comment.
I think we will quickly need graphs with multiple goal-nodes. Not sure about this although we could easily frame it up with goals=["Attacker gets data from bucket"] - what do you think?
| # Overload the default formatting shape if the Node is flagged as unimplemented | ||
| if unimplemented: | ||
| node_attr = node_attr | dotformat['_unimplemented_override'] | ||
| def __init__(self, root="Root", goal="Goal"): |
There was a problem hiding this comment.
Same comment as above, we likely do want multiple goals
|
This will break any other graphs people have been playing with (and I guess that means we need to quickly get to a stable pattern of models or some versioning or something) |
|
Very interesting point on multiple goals I had not thought of that TBH. I guess we could pass a strong or a list (either strings or actual Nodes) and depending on it set one or more elements. Goal1, goal2 or something like that it should not be difficult. Let me think about it and provide you a PoC, but you totally set a great point. |
