-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Celeste crashes syncing #239
Comments
+1 In case it's useful, it started happening since I had a dialog about local and remote not matching. It's only been a recent thing - last week or so, with no version change. Version is latest at time of writing. I tried:
It is non-deterministic for me - although it nearly always happens. I've managed to reproduce a very similar issue once on a local The interesting part of the backtrace is similar to the above (hence why I think it's the same): thread 'main' panicked at src/launch.rs:2489:33:
internal error: entered unreachable code
stack backtrace:
0: rust_begin_unwind
at /rustc/a2545fd6fc66b4323f555223a860c451885d1d2b/library/std/src/panicking.rs:665:5
1: core::panicking::panic_fmt
at /rustc/a2545fd6fc66b4323f555223a860c451885d1d2b/library/core/src/panicking.rs:76:14
2: core::panicking::panic
at /rustc/a2545fd6fc66b4323f555223a860c451885d1d2b/library/core/src/panicking.rs:148:5
3: celeste::launch::launch::sync_remote_directory
at ./src/launch.rs:2489:33
4: celeste::launch::launch
at ./src/launch.rs:2559:17
5: celeste::main::{{closure}}
at ./src/main.rs:95:25 Thanks for making this! I hope this is helpful. |
It is panicing on a file that I deleted remotely whilst trying to sync that change. Here are the timestamps: (gdb) p db_model.last_local_timestamp
$10 = 1732583291
(gdb) p db_model.last_remote_timestamp
$11 = 1732583291
(gdb) p l_timestamp
$12 = 1732583291
(gdb) p remote_timestamp
$13 = 1732583008 The file exists locally. |
The issue occurs when the remote timestamp in the DB is more recent than the next (i.e. time has gone backwards). It's not possible to know which is "really" more recent here, so the safest thing to do is to report an error and skip that file.
Fix in PR #240 |
For those that not compile from github, do you imagine how long will take to propagate the fix on snap (Ubuntu)? |
Up to the repo owner. |
Same here:
|
Bug Description
While Celeste is checking and encounter a cetain Google Drive folder, it crashes.
It is newly installed and never completed its first full sync process due to this crash.
If I exclude that directory, it goes ahead until finds another directory it dislikes.
Because don't exist a button for "pause sync" I have to exclude the directory before it crashes. Not easy!
Installation Source
Snap
What version of Celeste are you using?
Hunter Wittenborn
Storage Provider
Google Drive
The text was updated successfully, but these errors were encountered: