Move SwitchMethodPartitioning

Summary: SwitchMethodPartitioning was moved from its optimization to open source since it was touted as a general purpose utility. SwitchEquivFinder came later and is better at handling such jobs, and in the dependent diffs SwitchMethodPartitioning became just a holder for SwitchEquivFinder results that is catered to its caller. I see no value in having SwitchMethodPartitioning as a general purpose thing, move it to its use and further specialize it to do that task. Anything that wanted to use its functionality should be using SwitchEquivFinder anyways. Reviewed By: thezhangwei Differential Revision: D52213332 fbshipit-source-id: d198909c168431c2803ea89f3e163223a95b1b56
hurali97 · Dec 15, 2023 · a7a1c69 · a7a1c69
1 parent 1a8a348
commit a7a1c69
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 246 deletions.
diff --git a/Makefile.am b/Makefile.am
@@ -310,7 +310,6 @@ libredex_la_SOURCES = \
 	service/shrinker/Shrinker.cpp \
 	service/switch-dispatch/SwitchDispatch.cpp \
 	service/switch-partitioning/SwitchEquivFinder.cpp \
-	service/switch-partitioning/SwitchMethodPartitioning.cpp \
 	service/type-analysis/GlobalTypeAnalyzer.cpp \
 	service/type-analysis/LocalTypeAnalyzer.cpp \
 	service/type-analysis/WholeProgramState.cpp \

diff --git a/service/switch-partitioning/SwitchMethodPartitioning.cpp b/service/switch-partitioning/SwitchMethodPartitioning.cpp
diff --git a/service/switch-partitioning/SwitchMethodPartitioning.h b/service/switch-partitioning/SwitchMethodPartitioning.h
diff --git a/test/unit/Makefile.am b/test/unit/Makefile.am
@@ -132,7 +132,6 @@ check_PROGRAMS = \
     strip_debug_info_test \
     switch_dispatch_test \
     switch_equiv_test \
-    switch_partitioning_test \
     timer_test \
     trace_multithreading_test \
     true_virtuals_test \
@@ -430,8 +429,6 @@ switch_dispatch_test_SOURCES = SwitchDispatchTest.cpp
 switch_equiv_test_SOURCES = SwitchEquivFinderTest.cpp
 switch_equiv_test_LDADD = $(COMMON_MOCK_TEST_LIBS)
 
-switch_partitioning_test_SOURCES = SwitchPartitioningTest.cpp
-
 # throw_propagation_test_SOURCES = ThrowPropagationTest.cpp
 # throw_propagation_test_LDADD = $(COMMON_MOCK_TEST_LIBS)
 
@@ -591,7 +588,6 @@ TESTS = \
     strip_debug_info_test \
     switch_dispatch_test \
     switch_equiv_test \
-    switch_partitioning_test \
     timer_test \
     trace_multithreading_test \
     true_virtuals_test \

diff --git a/test/unit/SwitchPartitioningTest.cpp b/test/unit/SwitchPartitioningTest.cpp