"internal"

Summary: There are currently two different places where newly generated methods are adorned with "$oea$": 1) for reduced variants of root methods, and 2) for expanded methods where an object argument is replaced with a sequence field values. This is confusing. This diff makes it so that 1) gets a different name variation to make it easier to distinguish when debugging. Eventually, all those "internal" methods will get removed anyway. This is a behavior-preserving change. Reviewed By: beicy Differential Revision: D52410659 fbshipit-source-id: 3a595b5861d7da63dc11de22e0285d4ec76e41fb
hurali97 · Dec 28, 2023 · a77e4ba · a77e4ba
1 parent 2d870e6
commit a77e4ba
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/opt/object-escape-analysis/ObjectEscapeAnalysis.cpp b/opt/object-escape-analysis/ObjectEscapeAnalysis.cpp
@@ -1107,8 +1107,8 @@ compute_reduced_methods(
       [&](const std::pair<DexMethod*, InlinableTypes>& p) {
         auto* method = p.first;
         const auto& types = p.second;
-        auto copy_name_str =
-            method->get_name()->str() + "$oea$" + std::to_string(types.size());
+        auto copy_name_str = method->get_name()->str() + "$oea$internal$" +
+                             std::to_string(types.size());
         auto copy = DexMethod::make_method_from(
             method, method->get_class(), DexString::make_string(copy_name_str));
         RootMethodReducer root_method_reducer{expandable_method_params,