Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue2 attempt1 #3

Merged
merged 4 commits into from
Feb 1, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change grade version to 4.4+ and fix some syntax errors with dart. I …
…still have to fix some changes because Dart became more strongly typed
hungrymonkey committed Feb 1, 2019
commit 14735ec851b11953be276cb8f45aaa2d6fec9c87
1 change: 1 addition & 0 deletions android/build.gradle
Original file line number Diff line number Diff line change
@@ -28,6 +28,7 @@ android {

defaultConfig {
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
minSdkVersion = 16
}
lintOptions {
disable 'InvalidPackage'
2 changes: 1 addition & 1 deletion android/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -3,5 +3,5 @@
android:versionCode="1"
android:versionName="0.0.1">

<uses-sdk android:minSdkVersion="16" android:targetSdkVersion="21" />
<uses-sdk android:targetSdkVersion="21" />
</manifest>
2 changes: 1 addition & 1 deletion example/android/app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@
android:versionCode="1"
android:versionName="0.0.1">

<uses-sdk android:minSdkVersion="21" android:targetSdkVersion="21" />
<uses-sdk android:targetSdkVersion="21" />

<!-- The INTERNET permission is required for development. Specifically,
flutter needs it to communicate with the running application
4 changes: 3 additions & 1 deletion example/android/build.gradle
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
buildscript {
repositories {
jcenter()
google()
}

dependencies {
classpath 'com.android.tools.build:gradle:2.2.3'
classpath 'com.android.tools.build:gradle:3.2.1'
}
}

@@ -14,6 +15,7 @@ allprojects {
maven {
url "https://maven.google.com"
}
google()
}
}

4 changes: 2 additions & 2 deletions example/lib/utils.dart
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@ import 'dart:typed_data';
class Utils {
static num argmin(Float64List data){
num minIdx = -1;
num minVal = double.INFINITY;
num minVal = double.infinity;
for(var i = 0; i < data.length; i++){
if(data[i] < minVal ){
minIdx = i;
@@ -15,7 +15,7 @@ class Utils {
}
static num argmax(Float64List data){
num maxIdx = -1;
num maxVal = double.NEGATIVE_INFINITY;
num maxVal = double.negativeInfinity;
for(var i = 0; i < data.length; i++){
if(data[i] > maxVal ){
maxIdx = i;