detect symbolic link packages

* detect symbolic link packages
hugodias · Sep 8, 2020 · 6d6f204 · 6d6f204
1 parent 9b7614b
commit 6d6f204
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 1 deletion.
diff --git a/spec/fixtures/packages/folder/package-symlinked/package.json b/spec/fixtures/packages/folder/package-symlinked/package.json
@@ -0,0 +1,4 @@
+{
+  "name": "package-symlinked",
+  "version": "0.1.0"
+}
diff --git a/spec/package-manager-spec.js b/spec/package-manager-spec.js
@@ -1890,4 +1890,26 @@ describe('PackageManager', () => {
       });
     });
   });
+
+  describe('::getAvailablePackageNames', () => {
+    it('detects a symlinked package', () => {
+      const packageSymLinkedSource = path.join(
+        __dirname,
+        'fixtures',
+        'packages',
+        'folder',
+        'package-symlinked'
+      );
+      const destination = path.join(
+        atom.packages.getPackageDirPaths()[0],
+        'package-symlinked'
+      );
+      if (!fs.isDirectorySync(destination)) {
+        fs.symlinkSync(packageSymLinkedSource, destination, 'junction');
+      }
+      const availablePackages = atom.packages.getAvailablePackageNames();
+      expect(availablePackages.includes('package-symlinked')).toBe(true);
+      fs.removeSync(destination);
+    });
+  });
 });
diff --git a/src/package-manager.js b/src/package-manager.js
@@ -419,9 +419,16 @@ module.exports = class PackageManager {
 
     for (const packageDirPath of this.packageDirPaths) {
       if (fs.isDirectorySync(packageDirPath)) {
+        // checks for directories.
+        // dirent is faster, but for checking symbolic link we need stat.
         const packageNames = fs
           .readdirSync(packageDirPath, { withFileTypes: true })
-          .filter(dirent => dirent.isDirectory())
+          .filter(
+            dirent =>
+              dirent.isDirectory() ||
+              (dirent.isSymbolicLink() &&
+                fs.isDirectorySync(path.join(packageDirPath, dirent.name)))
+          )
           .map(dirent => dirent.name);
 
         for (const packageName of packageNames) {