Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is truncation_mode used in DPOTrainer? #2538

Open
anakin87 opened this issue Jan 2, 2025 · 0 comments
Open

Is truncation_mode used in DPOTrainer? #2538

anakin87 opened this issue Jan 2, 2025 · 0 comments
Labels
🏋 DPO Related to DPO ❓ question Seeking clarification or more information

Comments

@anakin87
Copy link
Contributor

anakin87 commented Jan 2, 2025

DPOConfig has a truncation_mode attribute. Docs
The only direct usage of it I can find in DPOTrainer is here:

trl/trl/trainer/dpo_trainer.py

Line 392 in 763738f

self.truncation_mode = args.truncation_mode

Some other trainers use this attribute: for example, KTO and BCO (search results).

I may be wrong, but my impression is that it was practically dropped in #2209 and #2306.

Could someone clarify if truncation_mode is still relevant for DPOTrainer?
My understanding is that we’d always want to keep the end when truncating for DPO, but I’d appreciate confirmation.
If I am right, let me know, and I would be happy to contribute with a PR to remove the unused arg.
@August-murr August-murr added ❓ question Seeking clarification or more information 🏋 DPO Related to DPO labels Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🏋 DPO Related to DPO ❓ question Seeking clarification or more information
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anakin87 @August-murr