Skip to content

Commit

Permalink
fix: verify jsonlines file in run_translation (#14660) (#14661)
Browse files Browse the repository at this point in the history
* fix: verify jsonl in run_translation (#14660)

* fix(run_translation.py): json/jsonl validation

Both json and jsonl are to be accepted as valid jsonlines file extension

* fix(run_translation.py): make black happy

* Ran make style
  • Loading branch information
GaurangTandon authored Dec 8, 2021
1 parent cf36f4d commit 4ea19de
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions examples/pytorch/translation/run_translation.py
Original file line number Diff line number Diff line change
Expand Up @@ -216,12 +216,16 @@ def __post_init__(self):
elif self.source_lang is None or self.target_lang is None:
raise ValueError("Need to specify the source language and the target language.")

# accepting both json and jsonl file extensions, as
# many jsonlines files actually have a .json extension
valid_extensions = ["json", "jsonl"]

if self.train_file is not None:
extension = self.train_file.split(".")[-1]
assert extension == "json", "`train_file` should be a json file."
assert extension in valid_extensions, "`train_file` should be a jsonlines file."
if self.validation_file is not None:
extension = self.validation_file.split(".")[-1]
assert extension == "json", "`validation_file` should be a json file."
assert extension in valid_extensions, "`validation_file` should be a jsonlines file."
if self.val_max_target_length is None:
self.val_max_target_length = self.max_target_length

Expand Down

0 comments on commit 4ea19de

Please sign in to comment.