Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 [i18n-KO] Translated guides/upload.md to Korean #2139

Merged
merged 8 commits into from
Apr 19, 2024
Merged

🌐 [i18n-KO] Translated guides/upload.md to Korean #2139

merged 8 commits into from
Apr 19, 2024

Conversation

junejae
Copy link
Contributor

@junejae junejae commented Mar 21, 2024 •
edited
Loading

What does this PR do?

Translated the guides/upload.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #1626

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

Team PseudoLab, may you please review this PR?
@jungnerd, @heuristicwave, @harheem, @cjfghk5697, @seoulsky-field, @nuatmochoi, @boyunJang, @SeungAhSon, @seoyoung-3060, @junejae

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@jungnerd, @heuristicwave May you please review this PR?

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

junejae
junejae commented Mar 21, 2024
View reviewed changes
Copy link
Contributor Author

@junejae junejae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anchor 추가

docs/source/ko/guides/upload.md Outdated
rendered properly in your Markdown viewer.
-->

# 허브에 파일 업로드하기
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# 허브에 파일 업로드하기
# 허브에 파일 업로드하기[[upload-files-to-the-hub]]

Anchor 추가

docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated

</Tip>

## (레거시) Git LFS로 파일 업로드하기
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## (레거시) Git LFS로 파일 업로드하기
## (레거시) Git LFS로 파일 업로드하기[[legacy-upload-files-with-git-lfs]]

docs/source/ko/guides/upload.md Outdated
매우 큰 파일이 있는 각 리포지토리에 대해 이 옵션을 설치해야 합니다.
설치가 완료되면 5GB보다 큰 파일을 푸시할 수 있습니다.

### 커밋 컨텍스트 관리자
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### 커밋 컨텍스트 관리자
### 커밋 컨텍스트 관리자[[commit-context-manager]]

docs/source/ko/guides/upload.md Outdated
>>> last_command.failed
```

### push_to_hub
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### push_to_hub
### push_to_hub[[pushtohub]]

SeungAhSon
SeungAhSon reviewed Mar 28, 2024
View reviewed changes
Copy link
Contributor

@SeungAhSon SeungAhSon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요! 좋은 번역 감사합니다.
허브 -> Hub로 용어를 통일하면 좋을 것 같아 코멘트를 남겼습니다.
앞으로 잘 부탁드려요 :)

docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
junejae
junejae commented Apr 2, 2024
View reviewed changes
Copy link
Contributor Author

@junejae junejae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

신규 정책에 맞게 주석 한글화 진행.

docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated
푸시 상태를 확인하는 데 유용한 몇 가지 추가 명령은 다음과 같습니다:

```python
# Inspect an error.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Inspect an error.
# 오류를 검사합니다.

docs/source/ko/guides/upload.md Outdated
# Inspect an error.
>>> last_command.stderr

# Check whether a push is completed or ongoing.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Check whether a push is completed or ongoing.
# 푸시 진행여부를 확인합니다.

docs/source/ko/guides/upload.md Outdated
# Check whether a push is completed or ongoing.
>>> last_command.is_done

# Check whether a push command has errored.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Check whether a push command has errored.
# 푸시 명령의 에러여부를 파악합니다.

junejae and others added 2 commits April 2, 2024 23:48
@junejae junejae marked this pull request as ready for review April 2, 2024 14:55
jungnerd
jungnerd reviewed Apr 18, 2024
View reviewed changes
Copy link
Contributor

@jungnerd jungnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일부 번역이 안된 주석이 있습니다! 확인 부탁드려요 🤗

docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
junejae
junejae commented Apr 18, 2024
View reviewed changes
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
@junejae
Copy link
Contributor Author

junejae commented Apr 18, 2024

일부 번역이 안된 주석이 있습니다! 확인 부탁드려요 🤗

@jungnerd 빠진 부분 작업 완료했습니다!

@jungnerd
Copy link
Contributor

jungnerd commented Apr 18, 2024 •
edited
Loading

@Wauplin LGTM. This PR is good to go!

Wauplin
Wauplin approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Thanks @junejae and reviewers! 🎉

@Wauplin Wauplin merged commit 19babe2 into huggingface:main Apr 19, 2024
2 checks passed
@stevhliu stevhliu mentioned this pull request May 16, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeungAhSon SeungAhSon SeungAhSon left review comments

@jungnerd jungnerd jungnerd left review comments

@Wauplin Wauplin Wauplin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@junejae @HuggingFaceDocBuilderDev @jungnerd @Wauplin @SeungAhSon