BREAKING CHANGE: selfId() might return undefined now

huangaszaq · Mar 2, 2020 · 5c0f036 · 5c0f036
1 parent d8b300f
commit 5c0f036
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/src/puppet.ts b/src/puppet.ts
@@ -386,12 +386,15 @@ export abstract class Puppet extends EventEmitter {
    */
   public abstract async logout (): Promise<void>
 
-  public selfId (): string {
+  public selfId (): undefined | string {
     log.verbose('Puppet', 'selfId()')
 
-    if (!this.id) {
-      throw new Error('not logged in, no this.id yet.')
-    }
+    /**
+     * Huan (202003): do not throw exception. deal `undefined` outside.
+     */
+    // if (!this.id) {
+    //   throw new Error('not logged in, no this.id yet.')
+    // }
 
     return this.id
   }