Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added attr-no-unnecessary-whitespace rule #220

Closed
wants to merge 9 commits into from
Closed

feat: added attr-no-unnecessary-whitespace rule #220

wants to merge 9 commits into from

Conversation

jakewtaylor
Copy link
Contributor

Shows an error like:
The attribute 'name' must not have spaces between the name and value.
for code like:

type = "text"
type ="text"
type= "text"

This is valid:

type="text"

@jakewtaylor
Copy link
Contributor Author

jakewtaylor commented Oct 20, 2017 •
edited
Loading

I've also added support for PHP files.

Anything between <?php/<? and ?> tags is stripped out and replaced with blank text with the same amount of newlines as before, so that errors still have the same line numbers.

I've added a test to check that PHP is properly ignored.

@jakewtaylor
Copy link
Contributor Author

jakewtaylor commented Oct 20, 2017 •
edited
Loading

Not really sure how to fix the coverage check failure - let me know how to get that to pass and I'll fix.

@thedaviddias thedaviddias added the feature request Functionality that introduces a new feature label Aug 23, 2018
@Shinigami92
Copy link
Contributor

Since lib/htmlhint.js is irrelevant to the current development phase, I think it is safe to merge this and bring it into the 'develop' branch

@thedaviddias thedaviddias changed the base branch from master to develop August 27, 2018 17:39
@thedaviddias thedaviddias mentioned this pull request Feb 24, 2019
Closed
2 tasks
@htmlhint htmlhint deleted a comment from coveralls May 14, 2020
@htmlhint htmlhint deleted a comment from coveralls May 14, 2020
@htmlhint htmlhint deleted a comment from coveralls May 14, 2020
@htmlhint htmlhint deleted a comment from coveralls May 14, 2020
@htmlhint htmlhint deleted a comment from coveralls May 14, 2020
@htmlhint htmlhint deleted a comment from coveralls May 14, 2020
@htmlhint htmlhint deleted a comment from coveralls May 14, 2020
@htmlhint htmlhint deleted a comment from coveralls May 14, 2020
@htmlhint htmlhint deleted a comment from coveralls May 14, 2020
@thedaviddias thedaviddias changed the title Added attr-no-unnecessary-whitespace rule feat: added attr-no-unnecessary-whitespace rule May 14, 2020
@thedaviddias thedaviddias mentioned this pull request May 16, 2020
Merged
@thedaviddias
Copy link
Member

Closing this old PR, reopened in #385 to speed up fixing merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature request Functionality that introduces a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakewtaylor @Shinigami92 @thedaviddias