HTML Hint Violation Report

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 553b6f5e3..1991f93fd 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -5,6 +5,7 @@ First, thank you for considering contributing to HTMLHint! It's people like you that make the open source community such a great community! 😊 We welcome any type of contribution, not only code. You can help with + - **QA**: file bug reports, the more details you can give the better (e.g. screenshots with the console open) - **Marketing**: writing blog posts, howto's, printing stickers, ... - **Community**: presenting the project at meetups, organizing a dedicated meetup for the local community, ... @@ -12,7 +13,7 @@ We welcome any type of contribution, not only code. You can help with ## Your First Contribution -Working on your first Pull Request? You can learn how from this *free* series, [How to Contribute to an Open Source Project on GitHub](https://egghead.io/series/how-to-contribute-to-an-open-source-project-on-github). +Working on your first Pull Request? You can learn how from this _free_ series, [How to Contribute to an Open Source Project on GitHub](https://egghead.io/series/how-to-contribute-to-an-open-source-project-on-github). ## Submitting code diff --git a/bin/formatter.js b/bin/formatter.js index a95f5b6d5..e54254a72 100644 --- a/bin/formatter.js +++ b/bin/formatter.js @@ -1,57 +1,59 @@ -var path = require('path'); -var events = require('events'); -var glob = require('glob'); -path.parse = path.parse || require('path-parse'); +var path = require('path') +var events = require('events') +var glob = require('glob') +path.parse = path.parse || require('path-parse') -var mapFormatters; -var arrSupportedFormatters; -var HTMLHint; -var options; +var mapFormatters +var arrSupportedFormatters +var HTMLHint +var options // load formatters -mapFormatters = loadFormatters(); -arrSupportedFormatters = []; -for(var formatterName in mapFormatters){ - if(formatterName !== 'default'){ - arrSupportedFormatters.push(formatterName); - } +mapFormatters = loadFormatters() +arrSupportedFormatters = [] +for (var formatterName in mapFormatters) { + if (formatterName !== 'default') { + arrSupportedFormatters.push(formatterName) + } } // load all formatters -function loadFormatters(){ - var arrFiles = glob.sync('./formatters/*.js', { - 'cwd': __dirname, - 'dot': false, - 'nodir': true, - 'strict': false, - 'silent': true - }); - var mapFormatters = {}; - arrFiles.forEach(function(file){ - var fileInfo = path.parse(file); - var formatterPath = path.resolve(__dirname, file); - mapFormatters[fileInfo.name] = require(formatterPath); - }); - return mapFormatters; +function loadFormatters() { + var arrFiles = glob.sync('./formatters/*.js', { + cwd: __dirname, + dot: false, + nodir: true, + strict: false, + silent: true, + }) + var mapFormatters = {} + arrFiles.forEach(function (file) { + var fileInfo = path.parse(file) + var formatterPath = path.resolve(__dirname, file) + mapFormatters[fileInfo.name] = require(formatterPath) + }) + return mapFormatters } -var formatter =new events.EventEmitter(); -formatter.getSupported = function(){ - return arrSupportedFormatters; -}; -formatter.init = function(tmpHTMLHint, tmpOptions){ - HTMLHint = tmpHTMLHint; - options = tmpOptions; -}; -formatter.setFormat = function(format){ - var formatHandel = mapFormatters[format]; - if(formatHandel === undefined){ - console.log('No supported formatter, supported formatters: %s'.red, arrSupportedFormatters.join(', ')); - process.exit(1); - } - else{ - formatHandel(formatter, HTMLHint, options); - } -}; +var formatter = new events.EventEmitter() +formatter.getSupported = function () { + return arrSupportedFormatters +} +formatter.init = function (tmpHTMLHint, tmpOptions) { + HTMLHint = tmpHTMLHint + options = tmpOptions +} +formatter.setFormat = function (format) { + var formatHandel = mapFormatters[format] + if (formatHandel === undefined) { + console.log( + 'No supported formatter, supported formatters: %s'.red, + arrSupportedFormatters.join(', ') + ) + process.exit(1) + } else { + formatHandel(formatter, HTMLHint, options) + } +} -module.exports = formatter; +module.exports = formatter diff --git a/bin/formatters/checkstyle.js b/bin/formatters/checkstyle.js index 1319430a5..fd54e7c25 100644 --- a/bin/formatters/checkstyle.js +++ b/bin/formatters/checkstyle.js @@ -1,48 +1,50 @@ -var xml = require('xml'); +var xml = require('xml') -var checkstyleFormatter = function(formatter){ - formatter.on('end', function(event){ - var arrFiles = []; - var arrAllMessages = event.arrAllMessages; - arrAllMessages.forEach(function(fileInfo){ - var arrMessages = fileInfo.messages; - var arrErrors = []; - arrMessages.forEach(function(message){ - arrErrors.push({ - error: { - _attr: { - line: message.line, - column: message.col, - severity: message.type, - message: message.message, - source: 'htmlhint.'+message.rule.id - } - } - }); - }); - arrFiles.push({ - file: [ - { - _attr: { - name: fileInfo.file - } - } - ].concat(arrErrors) - }); - }); - var objXml = { - checkstyle: [ - { - _attr: { - version: '4.3' - } - } - ].concat(arrFiles) - }; - console.log(xml(objXml, { - declaration: true, - indent: ' ' - })); - }); -}; -module.exports = checkstyleFormatter; +var checkstyleFormatter = function (formatter) { + formatter.on('end', function (event) { + var arrFiles = [] + var arrAllMessages = event.arrAllMessages + arrAllMessages.forEach(function (fileInfo) { + var arrMessages = fileInfo.messages + var arrErrors = [] + arrMessages.forEach(function (message) { + arrErrors.push({ + error: { + _attr: { + line: message.line, + column: message.col, + severity: message.type, + message: message.message, + source: 'htmlhint.' + message.rule.id, + }, + }, + }) + }) + arrFiles.push({ + file: [ + { + _attr: { + name: fileInfo.file, + }, + }, + ].concat(arrErrors), + }) + }) + var objXml = { + checkstyle: [ + { + _attr: { + version: '4.3', + }, + }, + ].concat(arrFiles), + } + console.log( + xml(objXml, { + declaration: true, + indent: ' ', + }) + ) + }) +} +module.exports = checkstyleFormatter diff --git a/bin/formatters/compact.js b/bin/formatters/compact.js index fc4ae8ae8..6748c3ba5 100644 --- a/bin/formatters/compact.js +++ b/bin/formatters/compact.js @@ -1,24 +1,25 @@ -var compactFormatter = function(formatter, HTMLHint, options){ - var nocolor = options.nocolor; - formatter.on('file', function(event){ - event.messages.forEach(function (message) { - console.log('%s: line %d, col %d, %s - %s (%s)', - event.file, - message.line, - message.col, - message.type, - message.message, - message.rule.id - ); - }); - }); - formatter.on('end', function(event){ - var allHintCount = event.allHintCount; - if(allHintCount > 0){ - console.log(''); - var message = '%d problems'; - console.log(nocolor ? message : message.red, event.allHintCount); - } - }); -}; -module.exports = compactFormatter; +var compactFormatter = function (formatter, HTMLHint, options) { + var nocolor = options.nocolor + formatter.on('file', function (event) { + event.messages.forEach(function (message) { + console.log( + '%s: line %d, col %d, %s - %s (%s)', + event.file, + message.line, + message.col, + message.type, + message.message, + message.rule.id + ) + }) + }) + formatter.on('end', function (event) { + var allHintCount = event.allHintCount + if (allHintCount > 0) { + console.log('') + var message = '%d problems' + console.log(nocolor ? message : message.red, event.allHintCount) + } + }) +} +module.exports = compactFormatter diff --git a/bin/formatters/default.js b/bin/formatters/default.js index 121348071..5c3c55f82 100644 --- a/bin/formatters/default.js +++ b/bin/formatters/default.js @@ -1,39 +1,44 @@ -var defaultFormatter = function(formatter, HTMLHint, options){ - var nocolor = options.nocolor; - formatter.on('start', function(){ - console.log(''); - }); - formatter.on('config', function(event){ - var configPath = event.configPath; - console.log(' Config loaded: %s', nocolor ? configPath : configPath.cyan); - console.log(''); - }); - formatter.on('file', function(event){ - console.log(' '+event.file.white); - var arrLogs = HTMLHint.format(event.messages, { - colors: nocolor ? false : true, - indent: 6 - }); - arrLogs.forEach(function(str){ - console.log(str); - }); - console.log(''); - }); - formatter.on('end', function(event){ - var allFileCount = event.allFileCount; - var allHintCount = event.allHintCount; - var allHintFileCount = event.allHintFileCount; - var time = event.time; - var message; - if(allHintCount > 0){ - message = 'Scanned %d files, found %d errors in %d files (%d ms)'; - console.log(nocolor ? message : message.red, allFileCount, allHintCount, allHintFileCount, time); - } - else{ - message = 'Scanned %d files, no errors found (%d ms).'; - console.log(nocolor ? message : message.green, allFileCount, time); - } - }); -}; +var defaultFormatter = function (formatter, HTMLHint, options) { + var nocolor = options.nocolor + formatter.on('start', function () { + console.log('') + }) + formatter.on('config', function (event) { + var configPath = event.configPath + console.log(' Config loaded: %s', nocolor ? configPath : configPath.cyan) + console.log('') + }) + formatter.on('file', function (event) { + console.log(' ' + event.file.white) + var arrLogs = HTMLHint.format(event.messages, { + colors: nocolor ? false : true, + indent: 6, + }) + arrLogs.forEach(function (str) { + console.log(str) + }) + console.log('') + }) + formatter.on('end', function (event) { + var allFileCount = event.allFileCount + var allHintCount = event.allHintCount + var allHintFileCount = event.allHintFileCount + var time = event.time + var message + if (allHintCount > 0) { + message = 'Scanned %d files, found %d errors in %d files (%d ms)' + console.log( + nocolor ? message : message.red, + allFileCount, + allHintCount, + allHintFileCount, + time + ) + } else { + message = 'Scanned %d files, no errors found (%d ms).' + console.log(nocolor ? message : message.green, allFileCount, time) + } + }) +} -module.exports = defaultFormatter; +module.exports = defaultFormatter diff --git a/bin/formatters/html.js b/bin/formatters/html.js index 8b2b9394e..da3631f52 100644 --- a/bin/formatters/html.js +++ b/bin/formatters/html.js @@ -1,26 +1,39 @@ -var fs = require('fs'); +var fs = require('fs') -var htmlFormatter = function(formatter){ - formatter.on('end', function(event){ - var fileContent; - fileContent = ''; - fileContent = fileContent + 'HTML Hint Violation Report'; - fileContent = fileContent + ''; - fileContent = fileContent + '

Violation Report

'; +var htmlFormatter = function (formatter) { + formatter.on('end', function (event) { + var fileContent + fileContent = '' + fileContent = + fileContent + 'HTML Hint Violation Report' + fileContent = fileContent + '' + fileContent = fileContent + '

Violation Report

' - fileContent = fileContent + ''; - fileContent = fileContent + ''; - var arrAllMessages = event.arrAllMessages; - arrAllMessages.forEach(function(fileInfo){ - var arrMessages = fileInfo.messages; - arrMessages.forEach(function(message){ - fileContent = fileContent + ''; - }); - }); - fileContent = fileContent.replace('

Number#	File Name	Line Number	Message
'+(i+1)+'	'+fileInfo.file+'	'+message.line+'	'+message.message+'

'); - console.log(fileContent); - fs.writeFileSync('report.html', fileContent); - }); -}; + fileContent = fileContent + '' + fileContent = + fileContent + + '' + var arrAllMessages = event.arrAllMessages + arrAllMessages.forEach(function (fileInfo) { + var arrMessages = fileInfo.messages + arrMessages.forEach(function (message, i) { + fileContent = + fileContent + + '' + }) + }) + fileContent = fileContent.replace('

Number#	File Name	Line Number	Message
' + + (i + 1) + + '	' + + fileInfo.file + + '	' + + message.line + + '	' + + message.message + + '

'); - }); - - it('should parse special no quotes tags', function(done) { - const parser = new HTMLParser(); - const arrEvents = []; + tagName: 'p', + }) + done() + }) + parser.parse('

') + }) + + it('should parse special no quotes tags', function (done) { + const parser = new HTMLParser() + const arrEvents = [] getAllEvents(parser, arrEvents, () => { expect(arrEvents[1]).to.event('tagstart', { - tagName: 'link' - }); + tagName: 'link', + }) expect(arrEvents[2]).to.event('tagstart', { - tagName: 'link' - }); - done(); - }); - parser.parse(''); - }); - - it('should parse special empty attr', function(done) { - const parser = new HTMLParser(); - const arrEvents = []; + tagName: 'link', + }) + done() + }) + parser.parse('') + }) + + it('should parse special empty attr', function (done) { + const parser = new HTMLParser() + const arrEvents = [] getAllEvents(parser, arrEvents, () => { expect(arrEvents[1]).to.event('tagstart', { tagName: 'img', - close: '' - }); - const attrs = arrEvents[1].attrs; - expect(attrs.length).to.be(2); - expect(attrs[1].name).to.be('alt'); - expect(attrs[1].value).to.be('/'); - done(); - }); - parser.parse('

'); - }); -}); + close: '', + }) + const attrs = arrEvents[1].attrs + expect(attrs.length).to.be(2) + expect(attrs[1].name).to.be('alt') + expect(attrs[1].value).to.be('/') + done() + }) + parser.parse('

') + }) +}) diff --git a/test/rules/alt-require.spec.js b/test/rules/alt-require.spec.js index c3d75e065..f8d707684 100644 --- a/test/rules/alt-require.spec.js +++ b/test/rules/alt-require.spec.js @@ -1,109 +1,109 @@ -const expect = require('expect.js'); - -const HTMLHint = require('../../dist/htmlhint.js').HTMLHint; - -const ruldId = 'alt-require'; -const ruleOptions = {}; - -ruleOptions[ruldId] = true; - -describe(`Rules: ${ruldId}`, function() { - it('Img tag have empty alt attribute should not result in an error', function() { - const code = ''; - const messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(0); - }); - - it('Img tag have non empty alt attribute should not result in an error', function() { - const code = ' test

'; - const messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(0); - }); - - it('Img tag have not alt attribute should result in an error', function() { - const code = ''; - const messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(1); - expect(messages[0].rule.id).to.be(ruldId); - expect(messages[0].line).to.be(1); - expect(messages[0].col).to.be(5); - expect(messages[0].type).to.be('warning'); - }); +const expect = require('expect.js') + +const HTMLHint = require('../../dist/htmlhint.js').HTMLHint + +const ruldId = 'alt-require' +const ruleOptions = {} + +ruleOptions[ruldId] = true + +describe(`Rules: ${ruldId}`, function () { + it('Img tag have empty alt attribute should not result in an error', function () { + const code = '' + const messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(0) + }) + + it('Img tag have non empty alt attribute should not result in an error', function () { + const code = ' test

'; - messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(2); - expect(messages[0].rule.id).to.be(ruldId); - expect(messages[0].line).to.be(2); - expect(messages[0].col).to.be(1); - expect(messages[1].rule.id).to.be(ruldId); - expect(messages[1].line).to.be(2); - expect(messages[1].col).to.be(13); - }); - - it('Lowercase attr should not result in an error', function() { - const code = '

'; - const messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(0); - }); - - it('Set is false should not result in an error', function() { - const code = '

'; - ruleOptions[ruldId] = false; - const messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(0); - }); - - it('Set to array list should not result in an error', function() { - const code = '

'; - ruleOptions[ruldId] = ['testBox', 'tttAAA']; - const messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(0); - }); - - it('Set to array list with RegExp should not result in an error', function() { - const code = '

'; - ruleOptions[ruldId] = ['testBox', /bind:.*/]; - const messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(0); - }); - - it('Set to array list with regex string should not result in an error', function() { - const code = '

'; - ruleOptions[ruldId] = ['testBox', '/\\[.*\\]/']; - const messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(0); - }); -}); +const expect = require('expect.js') + +const HTMLHint = require('../../dist/htmlhint.js').HTMLHint + +const ruldId = 'attr-lowercase' +const ruleOptions = {} + +ruleOptions[ruldId] = true + +describe(`Rules: ${ruldId}`, function () { + it('Not all lowercase attr should result in an error', function () { + let code = '

' + let messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(1) + expect(messages[0].rule.id).to.be(ruldId) + expect(messages[0].line).to.be(1) + expect(messages[0].col).to.be(3) + + code = '

' + messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(2) + expect(messages[0].rule.id).to.be(ruldId) + expect(messages[0].line).to.be(2) + expect(messages[0].col).to.be(1) + expect(messages[1].rule.id).to.be(ruldId) + expect(messages[1].line).to.be(2) + expect(messages[1].col).to.be(13) + }) + + it('Lowercase attr should not result in an error', function () { + const code = '

' + const messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(0) + }) + + it('Set is false should not result in an error', function () { + const code = '

' + ruleOptions[ruldId] = false + const messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(0) + }) + + it('Set to array list should not result in an error', function () { + const code = '

' + ruleOptions[ruldId] = ['testBox', 'tttAAA'] + const messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(0) + }) + + it('Set to array list with RegExp should not result in an error', function () { + const code = '

' + ruleOptions[ruldId] = ['testBox', /bind:.*/] + const messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(0) + }) + + it('Set to array list with regex string should not result in an error', function () { + const code = '

' + ruleOptions[ruldId] = ['testBox', '/\\[.*\\]/'] + const messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(0) + }) +}) diff --git a/test/rules/attr-no-duplication.spec.js b/test/rules/attr-no-duplication.spec.js index 8a94e5a68..0db0caf58 100644 --- a/test/rules/attr-no-duplication.spec.js +++ b/test/rules/attr-no-duplication.spec.js @@ -1,25 +1,25 @@ -const expect = require('expect.js'); +const expect = require('expect.js') -const HTMLHint = require('../../dist/htmlhint.js').HTMLHint; +const HTMLHint = require('../../dist/htmlhint.js').HTMLHint -const ruldId = 'attr-no-duplication'; -const ruleOptions = {}; +const ruldId = 'attr-no-duplication' +const ruleOptions = {} -ruleOptions[ruldId] = true; +ruleOptions[ruldId] = true -describe(`Rules: ${ruldId}`, function() { - it('Attribute name been duplication should result in an error', function() { - const code = 'bbb'; - const messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(1); - expect(messages[0].rule.id).to.be(ruldId); - expect(messages[0].line).to.be(1); - expect(messages[0].col).to.be(12); - }); +describe(`Rules: ${ruldId}`, function () { + it('Attribute name been duplication should result in an error', function () { + const code = 'bbb' + const messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(1) + expect(messages[0].rule.id).to.be(ruldId) + expect(messages[0].line).to.be(1) + expect(messages[0].col).to.be(12) + }) - it('Attribute name not been duplication should not result in an error', function() { - const code = 'bbb'; - const messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(0); - }); -}); + it('Attribute name not been duplication should not result in an error', function () { + const code = 'bbb' + const messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(0) + }) +}) diff --git a/test/rules/attr-no-unnecessary-whitespace.js b/test/rules/attr-no-unnecessary-whitespace.js index 6476dd893..18fc2b1b2 100644 --- a/test/rules/attr-no-unnecessary-whitespace.js +++ b/test/rules/attr-no-unnecessary-whitespace.js @@ -1,31 +1,31 @@ -var expect = require('expect.js'); +var expect = require('expect.js') -var HTMLHint = require('../../dist/htmlhint.js').HTMLHint; +var HTMLHint = require('../../dist/htmlhint.js').HTMLHint var ruldId = 'attr-no-unnecessary-whitespace', - ruleOptions = {}; + ruleOptions = {} -ruleOptions[ruldId] = true; +ruleOptions[ruldId] = true describe('Rules: ' + ruldId, function () { - it('Attribute with spaces should result in an error', function () { - var codes = [ - '

', - '

', - ]; - for (var i = 0; i < codes.length; i++) { - var messages = HTMLHint.verify(codes[i], ruleOptions); - expect(messages.length).to.be(1); - expect(messages[0].rule.id).to.be(ruldId); - expect(messages[0].line).to.be(1); - expect(messages[0].col).to.be(5); - } - }); + it('Attribute with spaces should result in an error', function () { + var codes = [ + '

', + '

', + ] + for (var i = 0; i < codes.length; i++) { + var messages = HTMLHint.verify(codes[i], ruleOptions) + expect(messages.length).to.be(1) + expect(messages[0].rule.id).to.be(ruldId) + expect(messages[0].line).to.be(1) + expect(messages[0].col).to.be(5) + } + }) - it('Attribute without spaces should not result in an error', function () { - var code = '

'; - var messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(0); - }); -}); + it('Attribute without spaces should not result in an error', function () { + var code = '

' + var messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(0) + }) +}) diff --git a/test/rules/attr-sort.spec.js b/test/rules/attr-sort.spec.js index 66688eefc..b95268092 100644 --- a/test/rules/attr-sort.spec.js +++ b/test/rules/attr-sort.spec.js @@ -1,38 +1,38 @@ -const expect = require('expect.js'); +const expect = require('expect.js') -const HTMLHint = require('../../dist/htmlhint.js').HTMLHint; +const HTMLHint = require('../../dist/htmlhint.js').HTMLHint -const ruleId = 'attr-sorted'; -const ruleOptions = {}; +const ruleId = 'attr-sorted' +const ruleOptions = {} -ruleOptions[ruleId] = true; +ruleOptions[ruleId] = true -describe(`Rules: ${ruleId}`, function() { - it('Attribute unsorted tags must result in an error', function() { - const code = '

'; +describe(`Rules: ${ruleId}`, function () { + it('Attribute unsorted tags must result in an error', function () { + const code = '

'; + it('Attribute unsorted tags that are unrecognizable should not throw error', function () { + const code = '

' - const messages = HTMLHint.verify(code, ruleOptions); + const messages = HTMLHint.verify(code, ruleOptions) - expect(messages.length).to.be(0); - }); + expect(messages.length).to.be(0) + }) - it('Attribute unsorted of tags of various types should throw error', function() { - const code = '

'; + it('Attribute unsorted of tags of various types should throw error', function () { + const code = '

'; - let messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(1); - expect(messages[0].rule.id).to.be(ruldId); - expect(messages[0].line).to.be(1); - }); +describe(`Rules: ${ruldId}`, function () { + it('Double spaces in attributes should result in an error', function () { + let code = '

'; - let messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(1); - expect(messages[0].rule.id).to.be(ruldId); - expect(messages[0].line).to.be(1); - }); + it('Leading/trailing white space should result in an error', function () { + let code = '

'; - let messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(2); - expect(messages[0].rule.id).to.be(ruldId); - expect(messages[0].line).to.be(1); - }); -}); + it('Double spaces and leading/trailing white space should result in an error', function () { + let code = '

' + let messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(2) + expect(messages[0].rule.id).to.be(ruldId) + expect(messages[0].line).to.be(1) + }) +}) diff --git a/test/rules/default.spec.js b/test/rules/default.spec.js index 7280ac258..5577f5d4b 100644 --- a/test/rules/default.spec.js +++ b/test/rules/default.spec.js @@ -1,11 +1,11 @@ -const expect = require('expect.js'); +const expect = require('expect.js') -const HTMLHint = require('../../dist/htmlhint.js').HTMLHint; +const HTMLHint = require('../../dist/htmlhint.js').HTMLHint -describe('Rules: default', function() { - it('should result 3 errors', function() { - const code = '

'; - const messages = HTMLHint.verify(code); - expect(messages.length).to.be(3); - }); -}); +describe('Rules: default', function () { + it('should result 3 errors', function () { + const code = '

test

'; - let messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(1); - expect(messages[0].type).to.be('warning'); - expect(messages[0].rule.id).to.be(ruldId); - expect(messages[0].line).to.be(1); - expect(messages[0].col).to.be(5); - - code = '

test

'; - messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(1); - expect(messages[0].rule.id).to.be(ruldId); - expect(messages[0].line).to.be(1); - expect(messages[0].col).to.be(5); - - code = '

test

'; - let messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(0); - - code = '

test

'; - messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(0); - - code = '

test

'; - messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(0); - }); -}); +const expect = require('expect.js') + +const HTMLHint = require('../../dist/htmlhint.js').HTMLHint + +const ruldId = 'id-class-ad-disabled' +const ruleOptions = {} + +ruleOptions[ruldId] = true + +describe(`Rules: ${ruldId}`, function () { + it('Id use ad keyword should result in an error', function () { + let code = '

test

' + let messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(1) + expect(messages[0].type).to.be('warning') + expect(messages[0].rule.id).to.be(ruldId) + expect(messages[0].line).to.be(1) + expect(messages[0].col).to.be(5) + + code = '

test

' + messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(1) + expect(messages[0].rule.id).to.be(ruldId) + expect(messages[0].line).to.be(1) + expect(messages[0].col).to.be(5) + }) + + it('Class use ad keyword should result in an error', function () { + let code = '

test

' + messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(1) + expect(messages[0].rule.id).to.be(ruldId) + expect(messages[0].line).to.be(1) + expect(messages[0].col).to.be(5) + }) + + it('Id and class no ad keyword used should not result in an error', function () { + let code = '

test

' + let messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(0) + + code = '

test

' + messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(0) + + code = '

test

' + messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(0) + }) +}) diff --git a/test/rules/id-class-value.spec.js b/test/rules/id-class-value.spec.js index 369eb6962..1b6c04542 100644 --- a/test/rules/id-class-value.spec.js +++ b/test/rules/id-class-value.spec.js @@ -1,93 +1,93 @@ -var expect = require('expect.js'); +var expect = require('expect.js') -var HTMLHint = require('../../dist/htmlhint.js').HTMLHint; +var HTMLHint = require('../../dist/htmlhint.js').HTMLHint var ruldId = 'id-class-value', ruleOptionsUnderline = {}, ruleOptionsDash = {}, ruleOptionsHump = {}, - ruleOptionsReg = {}; + ruleOptionsReg = {} -ruleOptionsUnderline[ruldId] = 'underline'; -ruleOptionsDash[ruldId] = 'dash'; -ruleOptionsHump[ruldId] = 'hump'; +ruleOptionsUnderline[ruldId] = 'underline' +ruleOptionsDash[ruldId] = 'dash' +ruleOptionsHump[ruldId] = 'hump' ruleOptionsReg[ruldId] = { regId: /^_[a-z\d]+(-[a-z\d]+)*$/, - message: 'Id and class value must meet regexp' -}; + message: 'Id and class value must meet regexp', +} -describe('Rules: ' + ruldId, function() { - it('Id and class value be not lower case and split by underline should result in an error', function() { - var code = '

'; - var messages = HTMLHint.verify(code, ruleOptionsUnderline); - expect(messages.length).to.be(2); - expect(messages[0].rule.id).to.be('id-class-value'); - expect(messages[0].line).to.be(1); - expect(messages[0].col).to.be(5); - expect(messages[0].type).to.be('warning'); - expect(messages[1].rule.id).to.be('id-class-value'); - expect(messages[1].line).to.be(1); - expect(messages[1].col).to.be(17); - expect(messages[1].type).to.be('warning'); - }); +describe('Rules: ' + ruldId, function () { + it('Id and class value be not lower case and split by underline should result in an error', function () { + var code = '

' + var messages = HTMLHint.verify(code, ruleOptionsUnderline) + expect(messages.length).to.be(2) + expect(messages[0].rule.id).to.be('id-class-value') + expect(messages[0].line).to.be(1) + expect(messages[0].col).to.be(5) + expect(messages[0].type).to.be('warning') + expect(messages[1].rule.id).to.be('id-class-value') + expect(messages[1].line).to.be(1) + expect(messages[1].col).to.be(17) + expect(messages[1].type).to.be('warning') + }) - it('Id and class value be lower case and split by underline should not result in an error', function() { - var code = '

'; - var messages = HTMLHint.verify(code, ruleOptionsUnderline); - expect(messages.length).to.be(0); - }); + it('Id and class value be lower case and split by underline should not result in an error', function () { + var code = '

' + var messages = HTMLHint.verify(code, ruleOptionsUnderline) + expect(messages.length).to.be(0) + }) - it('Id and class value be not lower case and split by dash should result in an error', function() { - var code = '

'; - var messages = HTMLHint.verify(code, { 'id-class-value': 'dash' }); - expect(messages.length).to.be(2); - expect(messages[0].rule.id).to.be('id-class-value'); - expect(messages[0].line).to.be(1); - expect(messages[0].col).to.be(5); - expect(messages[1].rule.id).to.be('id-class-value'); - expect(messages[1].line).to.be(1); - expect(messages[1].col).to.be(17); - }); + it('Id and class value be not lower case and split by dash should result in an error', function () { + var code = '

' + var messages = HTMLHint.verify(code, { 'id-class-value': 'dash' }) + expect(messages.length).to.be(2) + expect(messages[0].rule.id).to.be('id-class-value') + expect(messages[0].line).to.be(1) + expect(messages[0].col).to.be(5) + expect(messages[1].rule.id).to.be('id-class-value') + expect(messages[1].line).to.be(1) + expect(messages[1].col).to.be(17) + }) - it('Id and class value be lower case and split by dash should not result in an error', function() { - var code = '

'; - var messages = HTMLHint.verify(code, ruleOptionsDash); - expect(messages.length).to.be(0); - }); + it('Id and class value be lower case and split by dash should not result in an error', function () { + var code = '

' + var messages = HTMLHint.verify(code, ruleOptionsDash) + expect(messages.length).to.be(0) + }) - it('Id and class value be not meet hump style should result in an error', function() { - var code = '

'; - var messages = HTMLHint.verify(code, ruleOptionsHump); - expect(messages.length).to.be(2); - expect(messages[0].rule.id).to.be('id-class-value'); - expect(messages[0].line).to.be(1); - expect(messages[0].col).to.be(5); - expect(messages[1].rule.id).to.be('id-class-value'); - expect(messages[1].line).to.be(1); - expect(messages[1].col).to.be(17); - }); + it('Id and class value be not meet hump style should result in an error', function () { + var code = '

' + var messages = HTMLHint.verify(code, ruleOptionsHump) + expect(messages.length).to.be(2) + expect(messages[0].rule.id).to.be('id-class-value') + expect(messages[0].line).to.be(1) + expect(messages[0].col).to.be(5) + expect(messages[1].rule.id).to.be('id-class-value') + expect(messages[1].line).to.be(1) + expect(messages[1].col).to.be(17) + }) - it('Id and class value be meet hump style should not result in an error', function() { - var code = '

'; - var messages = HTMLHint.verify(code, ruleOptionsHump); - expect(messages.length).to.be(0); - }); + it('Id and class value be meet hump style should not result in an error', function () { + var code = '

' + var messages = HTMLHint.verify(code, ruleOptionsHump) + expect(messages.length).to.be(0) + }) - it('Id and class value be not meet regexp should result in an error', function() { - var code = '

'; - var messages = HTMLHint.verify(code, ruleOptionsReg); - expect(messages.length).to.be(2); - expect(messages[0].rule.id).to.be('id-class-value'); - expect(messages[0].line).to.be(1); - expect(messages[0].col).to.be(5); - expect(messages[1].rule.id).to.be('id-class-value'); - expect(messages[1].line).to.be(1); - expect(messages[1].col).to.be(16); - }); + it('Id and class value be not meet regexp should result in an error', function () { + var code = '

' + var messages = HTMLHint.verify(code, ruleOptionsReg) + expect(messages.length).to.be(2) + expect(messages[0].rule.id).to.be('id-class-value') + expect(messages[0].line).to.be(1) + expect(messages[0].col).to.be(5) + expect(messages[1].rule.id).to.be('id-class-value') + expect(messages[1].line).to.be(1) + expect(messages[1].col).to.be(16) + }) - it('Id and class value be meet regexp should not result in an error', function() { - var code = '

'; - var messages = HTMLHint.verify(code, ruleOptionsReg); - expect(messages.length).to.be(0); - }); -}); + it('Id and class value be meet regexp should not result in an error', function () { + var code = '

' + var messages = HTMLHint.verify(code, ruleOptionsReg) + expect(messages.length).to.be(0) + }) +}) diff --git a/test/rules/id-unique.spec.js b/test/rules/id-unique.spec.js index 7350d0de6..700f8ba1a 100644 --- a/test/rules/id-unique.spec.js +++ b/test/rules/id-unique.spec.js @@ -1,26 +1,26 @@ -const expect = require('expect.js'); +const expect = require('expect.js') -const HTMLHint = require('../../dist/htmlhint.js').HTMLHint; +const HTMLHint = require('../../dist/htmlhint.js').HTMLHint -const ruldId = 'id-unique'; -const ruleOptions = {}; +const ruldId = 'id-unique' +const ruleOptions = {} -ruleOptions[ruldId] = true; +ruleOptions[ruldId] = true -describe(`Rules: ${ruldId}`, function() { - it('Id redefine should result in an error', function() { - const code = '

'; - const messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(1); - expect(messages[0].rule.id).to.be(ruldId); - expect(messages[0].line).to.be(1); - expect(messages[0].col).to.be(26); - expect(messages[0].type).to.be('error'); - }); +describe(`Rules: ${ruldId}`, function () { + it('Id redefine should result in an error', function () { + const code = '

' + const messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(1) + expect(messages[0].rule.id).to.be(ruldId) + expect(messages[0].line).to.be(1) + expect(messages[0].col).to.be(26) + expect(messages[0].type).to.be('error') + }) - it('Id no redefine should not result in an error', function() { - const code = '

'; - const messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(0); - }); -}); + it('Id no redefine should not result in an error', function () { + const code = '

' + const messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(0) + }) +}) diff --git a/test/rules/inline-script-disabled.spec.js b/test/rules/inline-script-disabled.spec.js index cd7d57f82..d7771ade5 100644 --- a/test/rules/inline-script-disabled.spec.js +++ b/test/rules/inline-script-disabled.spec.js @@ -1,50 +1,50 @@ -const expect = require('expect.js'); +const expect = require('expect.js') -const HTMLHint = require('../../dist/htmlhint.js').HTMLHint; +const HTMLHint = require('../../dist/htmlhint.js').HTMLHint -const ruldId = 'inline-script-disabled'; -const ruleOptions = {}; +const ruldId = 'inline-script-disabled' +const ruleOptions = {} -ruleOptions[ruldId] = true; +ruleOptions[ruldId] = true -describe(`Rules: ${ruldId}`, function() { - it('Inline on event should result in an error', function() { +describe(`Rules: ${ruldId}`, function () { + it('Inline on event should result in an error', function () { const code = - '

'; - const messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(2); - expect(messages[0].rule.id).to.be(ruldId); - expect(messages[0].line).to.be(1); - expect(messages[0].col).to.be(26); - expect(messages[0].type).to.be('warning'); - expect(messages[1].col).to.be(66); - }); + '

' + const messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(2) + expect(messages[0].rule.id).to.be(ruldId) + expect(messages[0].line).to.be(1) + expect(messages[0].col).to.be(26) + expect(messages[0].type).to.be('warning') + expect(messages[1].col).to.be(66) + }) - it('onttt should not result in an error', function() { - const code = '

'; - const messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(0); - }); + it('onttt should not result in an error', function () { + const code = '

' + const messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(0) + }) - it('Javascript protocol [ javascript: ] should result in an error', function() { + it('Javascript protocol [ javascript: ] should result in an error', function () { let code = - '

'; - let messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(2); - expect(messages[0].rule.id).to.be(ruldId); - expect(messages[0].line).to.be(1); - expect(messages[0].col).to.be(11); - expect(messages[0].type).to.be('warning'); - expect(messages[1].col).to.be(42); + '

' + let messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(2) + expect(messages[0].rule.id).to.be(ruldId) + expect(messages[0].line).to.be(1) + expect(messages[0].col).to.be(11) + expect(messages[0].type).to.be('warning') + expect(messages[1].col).to.be(42) code = - 'test1 test2'; - messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(2); - expect(messages[0].rule.id).to.be(ruldId); - expect(messages[0].line).to.be(1); - expect(messages[0].col).to.be(9); - expect(messages[0].type).to.be('warning'); - expect(messages[1].col).to.be(48); - }); -}); + 'test1 test2' + messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(2) + expect(messages[0].rule.id).to.be(ruldId) + expect(messages[0].line).to.be(1) + expect(messages[0].col).to.be(9) + expect(messages[0].type).to.be('warning') + expect(messages[1].col).to.be(48) + }) +}) diff --git a/test/rules/inline-style-disabled.spec.js b/test/rules/inline-style-disabled.spec.js index a9883292f..1369ae215 100644 --- a/test/rules/inline-style-disabled.spec.js +++ b/test/rules/inline-style-disabled.spec.js @@ -1,24 +1,24 @@ -const expect = require('expect.js'); +const expect = require('expect.js') -const HTMLHint = require('../../dist/htmlhint.js').HTMLHint; +const HTMLHint = require('../../dist/htmlhint.js').HTMLHint -const ruldId = 'inline-style-disabled'; -const ruleOptions = {}; +const ruldId = 'inline-style-disabled' +const ruleOptions = {} -ruleOptions[ruldId] = true; +ruleOptions[ruldId] = true -describe(`Rules: ${ruldId}`, function() { - it('Inline style should result in an error', function() { - let code = '

'; - let messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(1); - expect(messages[0].rule.id).to.be(ruldId); - expect(messages[0].line).to.be(1); - expect(messages[0].col).to.be(11); - expect(messages[0].type).to.be('warning'); +describe(`Rules: ${ruldId}`, function () { + it('Inline style should result in an error', function () { + let code = '

'; - messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(1); - }); -}); + code = '

' + messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(1) + }) +}) diff --git a/test/rules/input-requires-label.spec.js b/test/rules/input-requires-label.spec.js index 700786683..7b2c0ad47 100644 --- a/test/rules/input-requires-label.spec.js +++ b/test/rules/input-requires-label.spec.js @@ -1,71 +1,67 @@ -const expect = require("expect.js"); - -const HTMLHint = require('../../dist/htmlhint.js').HTMLHint; - -const ruleId = 'input-requires-label'; -const ruleOptions = {}; - -ruleOptions[ruleId] = true; - -describe(`Rules: ${ruleId}`, function(){ - - describe('Successful cases', function() { - - it('Input tag with a matching label before should result in no error', function () { - var code = ''; - var messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(0); - }); - - it('Input tag with a matching label after should result in no error', function () { - var code = ' '; - var messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(0); - }); - }); - - - describe('Error cases', function() { - - it('Input tag with no matching label should result in an error', function () { - var code = ''; - var messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(1); - expect(messages[0].rule.id).to.be(ruleId); - expect(messages[0].line).to.be(1); - expect(messages[0].col).to.be(7); - expect(messages[0].type).to.be('warning'); - }); - - it('Input tag with label that doesn\'t match id should result in error', function () { - var code = ' '; - var messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(1); - expect(messages[0].rule.id).to.be(ruleId); - expect(messages[0].line).to.be(1); - expect(messages[0].col).to.be(7); - expect(messages[0].type).to.be('warning'); - }); - - it('Input tag with blank label:for should result in error', function () { - var code = ' '; - var messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(1); - expect(messages[0].rule.id).to.be(ruleId); - expect(messages[0].line).to.be(1); - expect(messages[0].col).to.be(7); - expect(messages[0].type).to.be('warning'); - }); - - it('Input tag with no id should result in error', function () { - var code = ' '; - var messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(1); - expect(messages[0].rule.id).to.be(ruleId); - expect(messages[0].line).to.be(1); - expect(messages[0].col).to.be(7); - expect(messages[0].type).to.be('warning'); - }); - }); - -}); +const expect = require('expect.js') + +const HTMLHint = require('../../dist/htmlhint.js').HTMLHint + +const ruleId = 'input-requires-label' +const ruleOptions = {} + +ruleOptions[ruleId] = true + +describe(`Rules: ${ruleId}`, function () { + describe('Successful cases', function () { + it('Input tag with a matching label before should result in no error', function () { + var code = '' + var messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(0) + }) + + it('Input tag with a matching label after should result in no error', function () { + var code = ' ' + var messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(0) + }) + }) + + describe('Error cases', function () { + it('Input tag with no matching label should result in an error', function () { + var code = '' + var messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(1) + expect(messages[0].rule.id).to.be(ruleId) + expect(messages[0].line).to.be(1) + expect(messages[0].col).to.be(7) + expect(messages[0].type).to.be('warning') + }) + + it("Input tag with label that doesn't match id should result in error", function () { + var code = + ' ' + var messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(1) + expect(messages[0].rule.id).to.be(ruleId) + expect(messages[0].line).to.be(1) + expect(messages[0].col).to.be(7) + expect(messages[0].type).to.be('warning') + }) + + it('Input tag with blank label:for should result in error', function () { + var code = ' ' + var messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(1) + expect(messages[0].rule.id).to.be(ruleId) + expect(messages[0].line).to.be(1) + expect(messages[0].col).to.be(7) + expect(messages[0].type).to.be('warning') + }) + + it('Input tag with no id should result in error', function () { + var code = ' ' + var messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(1) + expect(messages[0].rule.id).to.be(ruleId) + expect(messages[0].line).to.be(1) + expect(messages[0].col).to.be(7) + expect(messages[0].type).to.be('warning') + }) + }) +}) diff --git a/test/rules/script-disabled.spec.js b/test/rules/script-disabled.spec.js index 077818f6b..a451c69a0 100755 --- a/test/rules/script-disabled.spec.js +++ b/test/rules/script-disabled.spec.js @@ -1,25 +1,25 @@ var expect = require('expect.js'), - HTMLHint = require('../../dist/htmlhint.js').HTMLHint; + HTMLHint = require('../../dist/htmlhint.js').HTMLHint var ruldId = 'script-disabled', - ruleOptions = {}; -ruleOptions[ruldId] = true; -describe('Rules: ' + ruldId, function() { - it('Add external script file should result in an error', function() { + ruleOptions = {} +ruleOptions[ruldId] = true +describe('Rules: ' + ruldId, function () { + it('Add external script file should result in an error', function () { var code = '', - messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(1); - expect(messages[0].rule.id).to.be(ruldId); - expect(messages[0].line).to.be(1); - expect(messages[0].col).to.be(7); - expect(messages[0].type).to.be('error'); - }); - it('Add inline script should result in an error', function() { + messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(1) + expect(messages[0].rule.id).to.be(ruldId) + expect(messages[0].line).to.be(1) + expect(messages[0].col).to.be(7) + expect(messages[0].type).to.be('error') + }) + it('Add inline script should result in an error', function () { var code = '', - messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(1); - expect(messages[0].rule.id).to.be(ruldId); - expect(messages[0].line).to.be(1); - expect(messages[0].col).to.be(7); - expect(messages[0].type).to.be('error'); - }); -}); + messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(1) + expect(messages[0].rule.id).to.be(ruldId) + expect(messages[0].line).to.be(1) + expect(messages[0].col).to.be(7) + expect(messages[0].type).to.be('error') + }) +}) diff --git a/test/rules/space-tab-mixed-disabled.spec.js b/test/rules/space-tab-mixed-disabled.spec.js index 8fedd6552..eb394a380 100644 --- a/test/rules/space-tab-mixed-disabled.spec.js +++ b/test/rules/space-tab-mixed-disabled.spec.js @@ -1,135 +1,135 @@ -const expect = require('expect.js'); +const expect = require('expect.js') -const HTMLHint = require('../../dist/htmlhint.js').HTMLHint; +const HTMLHint = require('../../dist/htmlhint.js').HTMLHint -const ruldId = 'space-tab-mixed-disabled'; -const ruleMixOptions = {}; -const ruleSpaceOptions = {}; -const ruleSpace4Options = {}; -const ruleSpace5Options = {}; -const ruleTabOptions = {}; +const ruldId = 'space-tab-mixed-disabled' +const ruleMixOptions = {} +const ruleSpaceOptions = {} +const ruleSpace4Options = {} +const ruleSpace5Options = {} +const ruleTabOptions = {} -ruleMixOptions[ruldId] = true; -ruleSpaceOptions[ruldId] = 'space'; -ruleSpace4Options[ruldId] = 'space4'; -ruleSpace5Options[ruldId] = 'space5'; -ruleTabOptions[ruldId] = 'tab'; +ruleMixOptions[ruldId] = true +ruleSpaceOptions[ruldId] = 'space' +ruleSpace4Options[ruldId] = 'space4' +ruleSpace5Options[ruldId] = 'space5' +ruleTabOptions[ruldId] = 'tab' -describe(`Rules: ${ruldId}`, function() { - it('Spaces and tabs mixed in front of line should result in an error', function() { +describe(`Rules: ${ruldId}`, function () { + it('Spaces and tabs mixed in front of line should result in an error', function () { // space before tab - let code = ' bbb'; - let messages = HTMLHint.verify(code, ruleMixOptions); - expect(messages.length).to.be(1); - expect(messages[0].rule.id).to.be(ruldId); - expect(messages[0].line).to.be(1); - expect(messages[0].col).to.be(1); + let code = ' bbb' + let messages = HTMLHint.verify(code, ruleMixOptions) + expect(messages.length).to.be(1) + expect(messages[0].rule.id).to.be(ruldId) + expect(messages[0].line).to.be(1) + expect(messages[0].col).to.be(1) // tab before space - code = ' bbb'; - messages = HTMLHint.verify(code, ruleMixOptions); - expect(messages.length).to.be(1); - expect(messages[0].rule.id).to.be(ruldId); - expect(messages[0].line).to.be(1); - expect(messages[0].col).to.be(1); + code = ' bbb' + messages = HTMLHint.verify(code, ruleMixOptions) + expect(messages.length).to.be(1) + expect(messages[0].rule.id).to.be(ruldId) + expect(messages[0].line).to.be(1) + expect(messages[0].col).to.be(1) // multi line - code = '

\r\n bbb'; - messages = HTMLHint.verify(code, ruleMixOptions); - expect(messages.length).to.be(1); - expect(messages[0].rule.id).to.be(ruldId); - expect(messages[0].line).to.be(2); - expect(messages[0].col).to.be(1); - }); - - it('Only spaces in front of line should not result in an error', function() { - let code = ' bbb'; - let messages = HTMLHint.verify(code, ruleMixOptions); - expect(messages.length).to.be(0); - - code = '

\r\n bbb'; - messages = HTMLHint.verify(code, ruleMixOptions); - expect(messages.length).to.be(0); - }); - - it('Only tabs in front of line should not result in an error', function() { - const code = ' bbb'; - const messages = HTMLHint.verify(code, ruleMixOptions); - expect(messages.length).to.be(0); - }); - - it('Not only space in front of line should result in an error', function() { + code = '

\r\n bbb' + messages = HTMLHint.verify(code, ruleMixOptions) + expect(messages.length).to.be(1) + expect(messages[0].rule.id).to.be(ruldId) + expect(messages[0].line).to.be(2) + expect(messages[0].col).to.be(1) + }) + + it('Only spaces in front of line should not result in an error', function () { + let code = ' bbb' + let messages = HTMLHint.verify(code, ruleMixOptions) + expect(messages.length).to.be(0) + + code = '

\r\n bbb' + messages = HTMLHint.verify(code, ruleMixOptions) + expect(messages.length).to.be(0) + }) + + it('Only tabs in front of line should not result in an error', function () { + const code = ' bbb' + const messages = HTMLHint.verify(code, ruleMixOptions) + expect(messages.length).to.be(0) + }) + + it('Not only space in front of line should result in an error', function () { // mixed 1 - let code = ' bbb'; - let messages = HTMLHint.verify(code, ruleSpaceOptions); - expect(messages.length).to.be(1); + let code = ' bbb' + let messages = HTMLHint.verify(code, ruleSpaceOptions) + expect(messages.length).to.be(1) // mixed 2 - code = ' bbb'; - messages = HTMLHint.verify(code, ruleSpaceOptions); - expect(messages.length).to.be(1); + code = ' bbb' + messages = HTMLHint.verify(code, ruleSpaceOptions) + expect(messages.length).to.be(1) // only tab - code = ' bbb'; - messages = HTMLHint.verify(code, ruleSpaceOptions); - expect(messages.length).to.be(1); - }); - - it('Not only space and 4 length in front of line should result in an error', function() { - const code = ' bbb'; - const messages = HTMLHint.verify(code, ruleSpace4Options); - expect(messages.length).to.be(1); + code = ' bbb' + messages = HTMLHint.verify(code, ruleSpaceOptions) + expect(messages.length).to.be(1) + }) + + it('Not only space and 4 length in front of line should result in an error', function () { + const code = ' bbb' + const messages = HTMLHint.verify(code, ruleSpace4Options) + expect(messages.length).to.be(1) expect(messages[0].message).to.be( 'Please use space for indentation and keep 4 length.' - ); - }); - - it('Only space and 4 length in front of line should not result in an error', function() { - const code = ' bbb'; - const messages = HTMLHint.verify(code, ruleSpace4Options); - expect(messages.length).to.be(0); - }); - - it('Not only space and 5 length in front of line should result in an error', function() { - const code = ' bbb'; - const messages = HTMLHint.verify(code, ruleSpace5Options); - expect(messages.length).to.be(1); + ) + }) + + it('Only space and 4 length in front of line should not result in an error', function () { + const code = ' bbb' + const messages = HTMLHint.verify(code, ruleSpace4Options) + expect(messages.length).to.be(0) + }) + + it('Not only space and 5 length in front of line should result in an error', function () { + const code = ' bbb' + const messages = HTMLHint.verify(code, ruleSpace5Options) + expect(messages.length).to.be(1) expect(messages[0].message).to.be( 'Please use space for indentation and keep 5 length.' - ); - }); - - it('Only space and 5 length in front of line should not result in an error', function() { - const code = ' bbb'; - const messages = HTMLHint.verify(code, ruleSpace5Options); - expect(messages.length).to.be(0); - }); - - it('Only space in front of line should not result in an error', function() { - const code = ' bbb'; - const messages = HTMLHint.verify(code, ruleSpaceOptions); - expect(messages.length).to.be(0); - }); - - it('Not only tab in front of line should result in an error', function() { + ) + }) + + it('Only space and 5 length in front of line should not result in an error', function () { + const code = ' bbb' + const messages = HTMLHint.verify(code, ruleSpace5Options) + expect(messages.length).to.be(0) + }) + + it('Only space in front of line should not result in an error', function () { + const code = ' bbb' + const messages = HTMLHint.verify(code, ruleSpaceOptions) + expect(messages.length).to.be(0) + }) + + it('Not only tab in front of line should result in an error', function () { // mixed 1 - let code = ' bbb'; - let messages = HTMLHint.verify(code, ruleTabOptions); - expect(messages.length).to.be(1); + let code = ' bbb' + let messages = HTMLHint.verify(code, ruleTabOptions) + expect(messages.length).to.be(1) // mixed 2 - code = ' bbb'; - messages = HTMLHint.verify(code, ruleTabOptions); - expect(messages.length).to.be(1); + code = ' bbb' + messages = HTMLHint.verify(code, ruleTabOptions) + expect(messages.length).to.be(1) // only space - code = ' bbb'; - messages = HTMLHint.verify(code, ruleTabOptions); - expect(messages.length).to.be(1); - }); + code = ' bbb' + messages = HTMLHint.verify(code, ruleTabOptions) + expect(messages.length).to.be(1) + }) - it('Only tab in front of line should not result in an error', function() { + it('Only tab in front of line should not result in an error', function () { // only tab - const code = ' bbb'; - const messages = HTMLHint.verify(code, ruleTabOptions); - expect(messages.length).to.be(0); - }); -}); + const code = ' bbb' + const messages = HTMLHint.verify(code, ruleTabOptions) + expect(messages.length).to.be(0) + }) +}) diff --git a/test/rules/spec-char-escape.spec.js b/test/rules/spec-char-escape.spec.js index 85afb5452..a0d1ca999 100644 --- a/test/rules/spec-char-escape.spec.js +++ b/test/rules/spec-char-escape.spec.js @@ -1,48 +1,46 @@ -var expect = require("expect.js"); +var expect = require('expect.js') -var HTMLHint = require('../../dist/htmlhint.js').HTMLHint; +var HTMLHint = require('../../dist/htmlhint.js').HTMLHint var ruldId = 'spec-char-escape', - ruleOptions = {}; - -ruleOptions[ruldId] = true; - -describe('Rules: '+ruldId, function(){ - - it('Special characters: <> should result in an error', function(){ - var code = '

aaa>bbb< ccc

ddd\r\neee<'; - var messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(3); - expect(messages[0].rule.id).to.be(ruldId); - expect(messages[0].line).to.be(1); - expect(messages[0].col).to.be(7); - expect(messages[1].rule.id).to.be(ruldId); - expect(messages[1].line).to.be(1); - expect(messages[1].col).to.be(11); - expect(messages[2].rule.id).to.be(ruldId); - expect(messages[2].line).to.be(2); - expect(messages[2].col).to.be(4); - }); - - it('Special characters: & should result in an error', function(){ - var code = '

Steinway & Sons

'; - var messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(1); - expect(messages[0].rule.id).to.be(ruldId); - expect(messages[0].line).to.be(1); - expect(messages[0].col).to.be(12); - }); - - it('Normal text should not result in an error', function(){ - var code = '

abc

'; - var messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(0); - }); - - it('Properly formed HTML entities should not result in an error', function(){ - var code = '

Steinway & > Sons Q&A

'; - var messages = HTMLHint.verify(code, ruleOptions); - expect(messages.length).to.be(0); - }); - -}); + ruleOptions = {} + +ruleOptions[ruldId] = true + +describe('Rules: ' + ruldId, function () { + it('Special characters: <> should result in an error', function () { + var code = '

aaa>bbb< ccc

ddd\r\neee<' + var messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(3) + expect(messages[0].rule.id).to.be(ruldId) + expect(messages[0].line).to.be(1) + expect(messages[0].col).to.be(7) + expect(messages[1].rule.id).to.be(ruldId) + expect(messages[1].line).to.be(1) + expect(messages[1].col).to.be(11) + expect(messages[2].rule.id).to.be(ruldId) + expect(messages[2].line).to.be(2) + expect(messages[2].col).to.be(4) + }) + + it('Special characters: & should result in an error', function () { + var code = '

Steinway & Sons

' + var messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(1) + expect(messages[0].rule.id).to.be(ruldId) + expect(messages[0].line).to.be(1) + expect(messages[0].col).to.be(12) + }) + + it('Normal text should not result in an error', function () { + var code = '

abc

' + var messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(0) + }) + + it('Properly formed HTML entities should not result in an error', function () { + var code = '

Steinway & > Sons Q&A

' + var messages = HTMLHint.verify(code, ruleOptions) + expect(messages.length).to.be(0) + }) +}) diff --git a/test/rules/src-not-empty.spec.js b/test/rules/src-not-empty.spec.js index 096affcc9..9829feca4 100644 --- a/test/rules/src-not-empty.spec.js +++ b/test/rules/src-not-empty.spec.js @@ -1,31 +1,31 @@ -const expect = require('expect.js'); +const expect = require('expect.js') -const HTMLHint = require('../../dist/htmlhint.js').HTMLHint; +const HTMLHint = require('../../dist/htmlhint.js').HTMLHint -const ruldId = 'src-not-empty'; -const ruleOptions = {}; +const ruldId = 'src-not-empty' +const ruleOptions = {} -ruleOptions[ruldId] = true; +ruleOptions[ruldId] = true -describe(`Rules: ${ruldId}`, function() { - it('Src be emtpy should result in an error', function() { +describe(`Rules: ${ruldId}`, function () { + it('Src be emtpy should result in an error', function () { const code = - '