Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to non deprecated function calls #1930

Merged
merged 2 commits into from
May 17, 2024
Merged

Move to non deprecated function calls #1930

merged 2 commits into from
May 17, 2024

Conversation

augustocdias
Copy link
Contributor

vim.tbl_islist will be deprecated on 0.12. This make use of their replacement. I'm not sure what's the minimum version this function is available though...

@seblj
Copy link

seblj commented May 16, 2024

You can just do

local islist = vim.islist or vim.tbl_islist

And then use that, so that it won't stop working for the ones that haven't updated yet.

There is also a warning for vim.tbl_add_reverse_lookup if you want to tackle that as well

@augustocdias
Copy link
Contributor Author

You can just do

local islist = vim.islist or vim.tbl_islist

And then use that, so that it won't stop working for the ones that haven't updated yet.

There is also a warning for vim.tbl_add_reverse_lookup if you want to tackle that as well

Good point. Just did that. And about the other warning, I'm not sure what it should replace it with... There's nothing in the deprecation warning...

@seblj
Copy link

seblj commented May 16, 2024

And about the other warning, I'm not sure what it should replace it with... There's nothing in the deprecation warning...

You can probably find some examples in this where it was deprecated:

neovim/neovim@e52c25b

@purarue
Copy link

purarue commented May 16, 2024

There is also a warning for vim.tbl_add_reverse_lookup if you want to tackle that as well

Seems #1931 fixes that

@phush0
Copy link

phush0 commented May 17, 2024

other one is fixed already

@AThePeanut4
Copy link
Contributor

@augustocdias If you wouldn't mind adding the change here, this would probably be the easiest place to fix #1931 (comment)

@hrsh7th
Copy link
Owner

hrsh7th commented May 17, 2024

thank you

@hrsh7th hrsh7th merged commit abacd4c into hrsh7th:main May 17, 2024
AThePeanut4 added a commit to AThePeanut4/nvim-cmp that referenced this pull request Jul 15, 2024
AThePeanut4 added a commit to AThePeanut4/nvim-cmp that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants