Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

touchline: support for multiple controllers and config flow #136473

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

brondum
Copy link

@brondum brondum commented Jan 24, 2025

Proposed change

  • Moved setup to config flow
  • Added unique id to each thermostat to allow for area assignement etc.
  • Support for multiple Roth Controllers in a single HA instance.
  • Changed from the unmaintained pytouchline module to pytouchline_extended, which support multiple roth touchline controllers and just general maintained dependencies. (dependabot and a release pipeline is enabled on the repo as well). Checkout this pr for more details: change touchline dependency to pytouchline_extended #136362

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

A lot of the base of this PR is a continuation of #83484, so huge thanks to @pilehave for most of this PR.

This PR fixes the issue: fixes #80900
If you want to dive into changes between the pytouchline and pytouchline_extended you can check it out here:
abondoe/pytouchline@master...brondum:pytouchline:master

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing unique ID on touchline integration
1 participant