-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Config flow to ADS integration #130353
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review done.
I note from the documentation that ADS also supports other platforms such as light, switch, binary sensor, cover etc and that they usually require configuration in YAML, how will these be configured for users using ConfigFlow, is there an auto-discovery mechanism available?
In the scope of this PR, only the Hub can be set up by the ConfigFlow. The possibility remains to add it through the I am working on the possibility to set up the lights, switches etc... through the config flow, in separate PRs. Alternatively, there may be a way to auto discover devices, but i have to do a bit of testing. :) |
Ok, so in the meantime the user would be expected to set the hub up in ConfigFlow and then any extra devices in YAML? That seems a little odd unless there is a use case by which a user would want to only have a hub configured? Or is the plan to have all of these PRs merged in the same release cycle? |
Yes, it is a bit odd, but this PR is already pretty large, so i don't want to include all the other work in here. Also the possibility to set up the hub by YAML remains.
Yes, the plan is to mark each PR such as "Needs to be merged together with #...PR " |
In that case, please mark this as draft whilst work is ongoing. And think ahead about merge conflicts and so on. |
Proposed change
Add Config Flow to ADS integration, so from now on, the ADS hub can be set up from the frontend. YAML setup remains available.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: