Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config flow to Comfoconnect #122672

Draft
wants to merge 10 commits into
base: dev
Choose a base branch
from
Draft

Add config flow to Comfoconnect #122672

wants to merge 10 commits into from

Conversation

joostlek
Copy link
Member

@joostlek joostlek commented Jul 26, 2024 •
edited
Loading

Breaking change

Proposed change

Add config flow to Comfoconnect

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed config-flow This integration migrates to the UI by adding a config flow has-tests integration: comfoconnect new-feature labels Jul 26, 2024
@home-assistant
Copy link

Hey there @michaelarnauts, mind taking a look at this pull request as it has been labeled with an integration (comfoconnect) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of comfoconnect can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign comfoconnect Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@joostlek joostlek changed the title Add typing to Comfoconnect Add config flow to Comfoconnect Jul 26, 2024
@joostlek joostlek marked this pull request as ready for review July 27, 2024 06:08
@joostlek joostlek requested a review from michaelarnauts as a code owner July 27, 2024 06:08
@joostlek
Merge branch 'refs/heads/dev' into cccf
404bb03 
# Conflicts:
#	homeassistant/components/comfoconnect/__init__.py
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Aug 8, 2024
@joostlek
Merge branch 'dev' into cccf
fd12555 
# Conflicts:
#	homeassistant/components/comfoconnect/__init__.py
#	tests/components/comfoconnect/test_sensor.py
edenhaus
edenhaus reviewed Sep 25, 2024
View reviewed changes
homeassistant/components/comfoconnect/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/comfoconnect/__init__.py Outdated Show resolved Hide resolved
tests/components/comfoconnect/test_sensor.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove these tests?

joostlek and others added 2 commits September 25, 2024 11:10
@joostlek @edenhaus
Update homeassistant/components/comfoconnect/__init__.py
90a2042 
Co-authored-by: Robert Resch <robert@resch.dev>
@joostlek @edenhaus
Update homeassistant/components/comfoconnect/__init__.py
5a5d041 
Co-authored-by: Robert Resch <robert@resch.dev>
edenhaus
edenhaus requested changes Sep 25, 2024
View reviewed changes
homeassistant/components/comfoconnect/__init__.py Outdated

# Schedule disconnect on shutdown
def _shutdown(_event: Event) -> None:
ccb.disconnect()

hass.bus.listen_once(EVENT_HOMEASSISTANT_STOP, _shutdown)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should shutdown it on config entry unload instead of HA

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft September 25, 2024 09:28
@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Sep 27, 2024
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label Nov 26, 2024
@github-actions github-actions bot closed this Dec 3, 2024
@joostlek joostlek reopened this Dec 3, 2024
@github-actions github-actions bot removed the stale label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edenhaus edenhaus edenhaus requested changes

@michaelarnauts michaelarnauts Awaiting requested review from michaelarnauts michaelarnauts is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@michaelarnauts michaelarnauts

Labels
cla-signed config-flow This integration migrates to the UI by adding a config flow has-tests integration: comfoconnect new-feature Quality Scale: No score
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joostlek @edenhaus @frenck @michaelarnauts