Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config flow to filter helper #121522

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

Add config flow to filter helper #121522

wants to merge 10 commits into from

Conversation

gjohansson-ST
Copy link
Member

@gjohansson-ST gjohansson-ST commented Jul 8, 2024 •
edited
Loading

Proposed change

Add config flow to filter helper

Note that this is limited to using one filter only. For applying more than one filter it needs to be done through YAML (which remains as is)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed config-flow This integration migrates to the UI by adding a config flow integration: filter new-feature labels Jul 8, 2024
@home-assistant
Copy link

home-assistant bot commented Jul 8, 2024

Hey there @dgomes, mind taking a look at this pull request as it has been labeled with an integration (filter) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of filter can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign filter Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@gjohansson-ST gjohansson-ST added this to the 2024.8.0b0 milestone Jul 8, 2024
@dgomes
Copy link
Contributor

dgomes commented Jul 8, 2024

Thank you @gjohansson-ST for pushing this :)

Note that this is limited to using one filter only. For applying more than one filter it needs to be done through YAML (which remains as is)

This is the reason I've delayed indefinently touching this, I think at least a disclosure of this limitation should be added in the UI.

@gjohansson-ST gjohansson-ST mentioned this pull request Jul 8, 2024
Open
8 tasks
@gjohansson-ST gjohansson-ST marked this pull request as ready for review July 8, 2024 15:34
@gjohansson-ST gjohansson-ST requested a review from dgomes as a code owner July 8, 2024 15:34
dgomes
dgomes reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@dgomes dgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many filters actually use float variables. This UI might be too much limiting ...

homeassistant/components/filter/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/filter/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/filter/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/filter/config_flow.py Show resolved Hide resolved
homeassistant/components/filter/strings.json Outdated Show resolved Hide resolved
homeassistant/components/filter/strings.json Outdated Show resolved Hide resolved
homeassistant/components/filter/strings.json Outdated Show resolved Hide resolved
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 11, 2024
@dgomes dgomes mentioned this pull request Jul 15, 2024
Merged
20 tasks
@frenck frenck removed this from the 2024.8.0b0 milestone Jul 31, 2024
@frenck frenck added this to the 2024.11.0b0 milestone Sep 26, 2024
joostlek
joostlek requested changes Oct 21, 2024
View reviewed changes
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a merge conflict

homeassistant/components/filter/sensor.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft October 21, 2024 16:14
@gjohansson-ST gjohansson-ST marked this pull request as ready for review October 21, 2024 16:22
@home-assistant home-assistant bot requested a review from joostlek October 21, 2024 16:22
@gjohansson-ST gjohansson-ST mentioned this pull request Oct 21, 2024
Merged
19 tasks
@edenhaus edenhaus removed this from the 2024.11.0b0 milestone Oct 30, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the stale label Dec 29, 2024
@gjohansson-ST
Copy link
Member Author

Awaiting review still

@github-actions github-actions bot removed the stale label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elupus elupus elupus left review comments

@dgomes dgomes dgomes left review comments

@joostlek joostlek Awaiting requested review from joostlek

Requested changes must be addressed to merge this pull request.

Assignees

@dgomes dgomes

Labels
cla-signed config-flow This integration migrates to the UI by adding a config flow integration: filter new-feature Quality Scale: internal smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gjohansson-ST @dgomes @elupus @joostlek @frenck @edenhaus