Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache reactive parameters and root #850

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Cache reactive parameters and root #850

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b52bb9
Cache reactive parameters and root
philippjfr Sep 25, 2023
86894d6
Stop multiple execution when Trigger parameter is used
philippjfr Sep 25, 2023
7a9ef9f
Fix inverted logic
philippjfr Sep 25, 2023
8bc7584
Fix where implementation
philippjfr Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix inverted logic
  • Loading branch information
@philippjfr
philippjfr committed Sep 25, 2023
commit 7a9ef9fbec3a6bc19d2a2d43d49a6ade5ade14b5
2 changes: 1 addition & 1 deletion param/reactive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,7 @@ def __init__(
# that Trigger parameters do not cause double execution
self._params = [
p for p in self._internal_params if not isinstance(p.owner, Trigger)
or any (p in self._internal_params for p in p.owner.parameters)
or any (p not in self._internal_params for p in p.owner.parameters)
]
self._setup_invalidations(depth)
self._kwargs = kwargs
Expand Down