feat: remove in-memory SerializedModuleCache (#136)

* feat: remove in-memory SerializedModuleCache, move logic to perist serialized modules to filesystem into ModuleCache * chore: cleaner docs * chore: fmt + clippy * chore: rename fn for clarity * chore: clearer code * chore: comment clarity Co-authored-by: ThetaSinner <ThetaSinner@users.noreply.github.com> * chore: wording Co-authored-by: ThetaSinner <ThetaSinner@users.noreply.github.com> * chore: link to github discussion Co-authored-by: Jost <28270981+jost-s@users.noreply.github.com> * chore: clearer simpler naming without redundant 'Serialized' and 'Deserialized' * refactor: separate concerns ModuleBuilder from ModuleCache --------- Co-authored-by: ThetaSinner <ThetaSinner@users.noreply.github.com> Co-authored-by: Jost <28270981+jost-s@users.noreply.github.com>
holochain · Jan 7, 2025 · 4961063 · 4961063
1 parent 45cac55
commit 4961063
Show file tree

Hide file tree

Showing 7 changed files with 314 additions and 237 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/common/src/result.rs b/crates/common/src/result.rs
@@ -35,8 +35,6 @@ pub enum WasmErrorInner {
     ModuleBuild(String),
     /// The host failed to call a function in the guest.
     CallError(String),
-    /// Host attempted to interact with the module cache before it was initialized.
-    UninitializedSerializedModuleCache,
 }
 
 impl WasmErrorInner {
@@ -55,8 +53,6 @@ impl WasmErrorInner {
             | Self::ModuleBuild(_)
             // This is ambiguous so best to treat as potentially corrupt.
             | Self::CallError(_)
-            // We have no cache so cannot cache.
-            | Self::UninitializedSerializedModuleCache
              => true,
             // (De)serialization simply means some input/output data was
             // unrecognisable somehow, it doesn't corrupt the guest memory.

diff --git a/crates/host/Cargo.toml b/crates/host/Cargo.toml
@@ -6,6 +6,11 @@ version = "0.0.97"
 authors = ["thedavidmeister", "thedavidmeister@gmail.com"]
 edition = "2021"
 
+[lib]
+name = "holochain_wasmer_host"
+crate-type = ["cdylib", "rlib"]
+path = "src/lib.rs"
+
 [dependencies]
 wasmer = { version = "5.0.2", default-features = false }
 wasmer-middlewares = { version = "5.0.2", optional = true }
@@ -20,10 +25,8 @@ bytes = "1"
 hex = "0.4"
 thiserror = "2"
 
-[lib]
-name = "holochain_wasmer_host"
-crate-type = ["cdylib", "rlib"]
-path = "src/lib.rs"
+[dev-dependencies]
+tempfile = "3.14.0"
 
 [features]
 default = ["error_as_host", "wasmer_sys_dev"]