Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live Player #162

Open
fonsecapeter opened this issue Dec 22, 2022 · 4 comments
Open

Live Player #162

fonsecapeter opened this issue Dec 22, 2022 · 4 comments

Comments

@fonsecapeter
Copy link
Contributor

Hi!

Just came across this cool project by @henryefranks that includes a bash-cli live-player for spotify – thought it might be a great idea to add this (or something built off of it) under a new player argument.

Would be happy to throw up a PR if y'all think thats a good idea?

Screen Shot 2022-12-21 at 6 23 31 PM
@hnarayanan
Copy link
Owner

You could try, but I feel like the other project is remarkably similar to this one. I’m not sure how happy that the author would be if you took this primary feature brought it to shpotify.

@henryefranks
Copy link

Hey! I haven't thought about that script in a while, glad to see people still find it cool. I'm more than happy for you to bring the feature to shpotify, so I've just added an MIT license to the repo which I believe should let you use the code. Gimme a shout if you need a hand, and have fun!

@fonsecapeter
Copy link
Contributor Author

fonsecapeter commented Jan 3, 2023 •
edited
Loading

Awesome, thanks @henryefranks! Definitely find it cool 😎

I'll go ahead and throw up a PR then when I have some time, am thinking something that combines the bash-spotify player with the existing shpotify status if that sounds good to you @hnarayanan?

@hnarayanan
Copy link
Owner

Sounds good, as long as it doesn't add any obvious dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hnarayanan @fonsecapeter @henryefranks