Polygon display #128
Closed
Polygon display #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @will-moore. Exactly the layer I had in mind. Perhaps I would however like to wait on this being defined first in OME-NGFF if that is ok. In general, I'd like to avoid inventing more "vizarr concepts" (by adding query parameters for example) since it isn't clear how these parameters should be parsed for the various views of OME-NGFF. For example, what is the behaviour of |
|
Agreed. Closing for now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #127
Since this is a feature I expect to be of use to OME and others, I started to look at supporting viewing Polygons in vizarr.
Initially this uses query params e.g.
?polygons=[[[100,100],[100,200],[110,180],[200,250]],[[10,0],[50,120],[75,0]]]&strokeColor=ff0000in the screenshot below or try: https://deploy-preview-128--vizarr.netlify.app/?source=https://minio-dev.openmicroscopy.org/idr/v0.3/datasets/idr0062/8dc4707/7754.zarr/B1_C1.tif/&polygons=[[[100,100],[100,200],[110,180],[200,250]],[[10,0],[50,120],[75,0]]]&strokeColor=ff0000That has the obvious limitation of all Polygons being the same colour and same line width. Fill Colour isn't supported either.
I'll look at adding methods to the notebook API...