Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix launch tests for CI #37

Merged
merged 2 commits into from
Mar 18, 2023
Merged

Fix launch tests for CI #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cabd19f
Attempt to fix launch tests for CI
hmakelin Mar 18, 2023
b3ae5a7
Move dev dependency install to docker image
hmakelin Mar 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .github/workflows/build_and_deploy_sphinx_docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,9 @@ jobs:
run:
shell: bash
steps:
- name: Install GISNav developer dependencies
run: |
cd ~/colcon_ws/src/gisnav
python3 -m pip install -r requirements-dev.txt

- name: Build Sphinx docs
run: |
cd ~/colcon_ws
cd /home/gisnav/colcon_ws
source /opt/ros/foxy/setup.bash
source install/setup.bash
cd src/gisnav
Expand Down
10 changes: 0 additions & 10 deletions .github/workflows/run_ros2_launch_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,24 +9,14 @@ on:
# Allows running manually from the Actions tab
workflow_dispatch:

#env:
# REGISTRY: ghcr.io
# IMAGE_NAME: ${{ github.repository }}

jobs:
run:
runs-on: ubuntu-20.04
#container: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:latest
container: ghcr.io/${{ github.repository }}:latest
defaults:
run:
shell: bash
steps:
- name: Install GISNav developer dependencies
run: |
cd /home/gisnav/colcon_ws/src/gisnav
python3 -m pip install -r requirements-dev.txt

- name: Run ROS 2 launch tests
run: |
cd /home/gisnav/colcon_ws
Expand Down
23 changes: 23 additions & 0 deletions .github/workflows/static_analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Run ROS 2 launch tests

on:
workflow_run:
workflows: [ "Build and upload gisnav Docker image to GHCR" ]
types:
- completed

# Allows running manually from the Actions tab
workflow_dispatch:

jobs:
analyze:
runs-on: ubuntu-20.04
container: ghcr.io/${{ github.repository }}:latest
defaults:
run:
shell: bash
steps:
- name: Run pre-commit
run: |
cd /home/gisnav/colcon_ws/src/gisnav
pre-commit run --all-files
3 changes: 2 additions & 1 deletion docker/gisnav/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ RUN sudo chmod +x docker/gisnav/entrypoint.sh
RUN rosdep update && \
rosdep install --from-paths . -y -r --ignore-src && \
sudo apt-get -y install python3-pip && \
pip install -r requirements.txt
pip install -r requirements.txt && \
pip install -r requirements-dev.txt

# Install GDAL
RUN sudo apt-get -y install software-properties-common && \
Expand Down