This repository has been archived by the owner on Oct 3, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishesh92
commented
Jan 29, 2020
Fix UnboundLocalError: local variable 'is_uptime' referenced before assignment
In which situation do you see this error? Maybe when periods overlap? Please paste some logs from before the stacktrace. |
I am using version
|
Can you add a test case which fails before the fix and succeeds afterwards? |
Note that your deployment will not scale up if you only have "downscale-period" (see README). |
I'm facing the same issue, and it's quite simple to test. I've created the following deployment:
When checking the logfile at a time, which is outside the range as specified by the downscale-period, it shows the following:
|
hjacobs
added a commit
that referenced
this pull request
Feb 7, 2020
hjacobs
added a commit
that referenced
this pull request
Feb 7, 2020
Fixed in #86 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.