Fix record ctor with throws

hirsute-chauve · Mar 2, 2020 · fc0b437 · fc0b437
1 parent f49a6db
commit fc0b437
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/pmd-java/etc/grammar/Java.jjt b/pmd-java/etc/grammar/Java.jjt
@@ -1152,9 +1152,15 @@ void RecordBody():
 void RecordBodyDeclaration() #void :
 {}
 {
-  LOOKAHEAD(ClassOrInterfaceBodyDeclaration()) ClassOrInterfaceBodyDeclaration()
+  LOOKAHEAD(RecordCtorLookahead()) RecordConstructorDeclaration()
   |
-  RecordConstructorDeclaration()
+  ClassOrInterfaceBodyDeclaration()
+}
+
+private void RecordCtorLookahead() #void:
+{}
+{
+    Modifiers() [ TypeParameters() ] <IDENTIFIER> ("throws" |  "{")
 }
 
 void RecordConstructorDeclaration():
@@ -1165,6 +1171,7 @@ void RecordConstructorDeclaration():
   modifiers = Modifiers() { jjtThis.setModifiers(modifiers); }
   [TypeParameters()]
   <IDENTIFIER> { jjtThis.setImage(token.image); }
+  [ "throws" NameList() ]
   "{" ( BlockStatement() )* "}"
 }
 

diff --git a/.../src/test/resources/net/sourceforge/pmd/lang/java/ast/jdkversiontests/java14/Records.java b/.../src/test/resources/net/sourceforge/pmd/lang/java/ast/jdkversiontests/java14/Records.java
@@ -1,3 +1,4 @@
+import java.io.IOException;
 import java.lang.annotation.Target;
 import java.lang.annotation.ElementType;
 
@@ -54,5 +55,10 @@ public interface Person {
         String lastName();
     }
     public record PersonRecord(String firstName, String lastName)
-        implements Person, java.io.Serializable { }
+        implements Person, java.io.Serializable {
+
+        PersonRecord throws IOException { // compact ctor with throws list
+            throw new IOException();
+        }
+    }
 }