Skip to content

Commit

Permalink
fix: specify envtest version to avoid golang version format (kubeflow…
Browse files Browse the repository at this point in the history
…#7589)

Signed-off-by: mishraprafful <mishraprafful@gmail.com>
  • Loading branch information
mishraprafful authored May 28, 2024
1 parent 3f7ecfc commit f791158
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion components/notebook-controller/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,11 @@ kustomize: ## Download kustomize locally if necessary.
$(call go-get-tool,$(KUSTOMIZE),sigs.k8s.io/kustomize/v3/cmd/kustomize@v3.2.0)

ENVTEST = $(shell pwd)/bin/setup-envtest
ENVTEST_VERSION?=release-0.14

.PHONY: envtest
envtest: ## Download envtest-setup locally if necessary.
$(call go-get-tool,$(ENVTEST),sigs.k8s.io/controller-runtime/tools/setup-envtest@latest)
$(call go-get-tool,$(ENVTEST),sigs.k8s.io/controller-runtime/tools/setup-envtest@$(ENVTEST_VERSION))

# go-get-tool will 'go get' any package $2 and install it to $1.
PROJECT_DIR := $(shell dirname $(abspath $(lastword $(MAKEFILE_LIST))))
Expand Down

0 comments on commit f791158

Please sign in to comment.