From 924910b1bc09d439f4b6d8abb51132a545291af1 Mon Sep 17 00:00:00 2001 From: Rukesh Kapuluru Date: Mon, 20 Mar 2023 17:50:46 +1100 Subject: [PATCH] fix: upgrade to v13 --- hip_data_tools/google/googleads.py | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/hip_data_tools/google/googleads.py b/hip_data_tools/google/googleads.py index 6c49823..afffe60 100644 --- a/hip_data_tools/google/googleads.py +++ b/hip_data_tools/google/googleads.py @@ -277,7 +277,8 @@ def _refine_result_list( number_of_workers: int, page_size: int, result: list, total_entries: int ) -> None: last_page_size = total_entries % page_size - number_of_workers_with_non_zero_pages = math.ceil(total_entries / page_size) + number_of_workers_with_non_zero_pages = math.ceil( + total_entries / page_size) for workers_with_non_zero_pages in range(number_of_workers_with_non_zero_pages): result[workers_with_non_zero_pages]["number_of_pages"] = 1 result[workers_with_non_zero_pages]["page_size"] = page_size @@ -285,7 +286,8 @@ def _refine_result_list( number_of_workers_with_non_zero_pages, number_of_workers ): result[worker_with_zero_pages]["start_index"] = 0 - result[number_of_workers_with_non_zero_pages - 1]["page_size"] = last_page_size + result[number_of_workers_with_non_zero_pages - + 1]["page_size"] = last_page_size def _refine_page_confings( @@ -362,7 +364,8 @@ def get_parallel_payloads( result[0]["number_of_pages"] = 1 result[0]["page_size"] = total_entries elif page_size * number_of_workers > total_entries: - _refine_result_list(number_of_workers, page_size, result, total_entries) + _refine_result_list(number_of_workers, + page_size, result, total_entries) return result def _get_total_entries(self) -> int: @@ -383,7 +386,7 @@ class GoogleAdsCustomerUtil(AdWordsDataReader): """ def __init__(self, conn: GoogleAdsConnectionManager): - super().__init__(conn, service="CustomerService", version="v10") + super().__init__(conn, service="CustomerService", version="v13") def get_customers(self) -> List[dict]: """ @@ -413,7 +416,7 @@ class GoogleAdsClicksConversionUtil(GoogleAdsUtil): """ def __init__(self, conn: GoogleAdsConnectionManager): - super().__init__(conn, type="ClickConversion", version="v10") + super().__init__(conn, type="ClickConversion", version="v13") def click_conversion(self, data): """ @@ -442,7 +445,7 @@ class GoogleAdsUploadClickConversionsRequestUtil(GoogleAdsUtil): """ def __init__(self, conn: GoogleAdsConnectionManager): - super().__init__(conn, type="UploadClickConversionsRequest", version="v10") + super().__init__(conn, type="UploadClickConversionsRequest", version="v13") def upload_click_conversion(self, customer_id: str, click_conversion): """ @@ -467,7 +470,7 @@ class GoogleAdsConversionActionUtil(GoogleAdsUtil): """ def __init__(self, conn: GoogleAdsConnectionManager): - super().__init__(conn, service="ConversionActionService", version="v10") + super().__init__(conn, service="ConversionActionService", version="v13") def get_conversion_action(self, customer_id: str, conversion_action_id: str): """ @@ -489,7 +492,7 @@ class GoogleAdsOfflineConversionUtil(GoogleAdsUtil): """ def __init__(self, conn: GoogleAdsConnectionManager): - super().__init__(conn, service="ConversionUploadService", version="v10") + super().__init__(conn, service="ConversionUploadService", version="v13") self.required_fields = [ "gclid", "conversion_action",