feat: [TMX-1460] add function mlflow_decision_to_promote #42
+427
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⛔ Snyk checks have failed. 3 issues have been found so far.
⛔ security/snyk check is complete. 3 issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
shumingpeh
reviewed
Dec 20, 2024
shumingpeh
reviewed
Dec 20, 2024
| @patch( | ||
| "hip_data_ml_utils.mlflow_databricks.mlflow_model_utils.mlflow_promote_model" # noqa: E501 | ||
| ) | ||
| def test_decision_to_promote(self): |
There was a problem hiding this comment.
just to be consistent, the prefix is test_, + function_name.
so it will be test_mlflow_decision_to_promote
|
Closed pending local unit testing rather than running the full CI. This was not previously possible. |
…onger supported in v2
shumingpeh
reviewed
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add function mlflow_decision_to_promote.
Type
Description
mlflow_decision_to_promote function added to mlflow_model_utils. This function is a wrapper for mlflow_promote_model but first decides whether promotion should happen based on the environment and a metric compared between champion and challenger models.
Jira Link
https://hipagesgroup.atlassian.net/browse/TMX-1460
Checklist before submitting: