Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [TMX-1206] add function parameters for input examples and model signature #41

Merged
merged 5 commits into from
Oct 9, 2024
Merged

feat: [TMX-1206] add function parameters for input examples and model signature #41

merged 5 commits into from
Oct 9, 2024

Conversation

shumingpeh
Copy link
Contributor

@shumingpeh shumingpeh commented Oct 8, 2024 •
edited
Loading

Summary

add function parameters for input examples and model signature

Type

Check one that is relevant

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature and improvements (non-breaking change which adds/improves functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Code Refactoring (internal change which is not user facing)
  • Documentation
  • Test, CI, or build

Description

add function parameters for input examples and model signature

Jira Link

Link to relevant Jira tickets, stories, epic

Checklist before submitting:

  • Have you followed the general guidelines of GitFlow or GitHub Flow?
  • Have you verified no Secrets/Credentials present in commit ?
  • Have you updated test cases relevant for your code changes?
  • Have you verified all test are passing?
  • Have you verified you code is compliant with best practices?

wattychops
wattychops approved these changes Oct 8, 2024
View reviewed changes
Copy link

@wattychops wattychops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtn

@shumingpeh shumingpeh merged commit f49728d into master Oct 9, 2024
10 checks passed
@shumingpeh shumingpeh deleted the tmx-1206 branch October 9, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wattychops wattychops wattychops approved these changes

@stimsoni9 stimsoni9 Awaiting requested review from stimsoni9 stimsoni9 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shumingpeh @wattychops