Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [TMX-1043] change the pytorch model type naming when loading the model #40

Merged
merged 3 commits into from
Aug 12, 2024
Merged

fix: [TMX-1043] change the pytorch model type naming when loading the model #40

merged 3 commits into from
Aug 12, 2024

Conversation

shumingpeh
Copy link
Contributor

Summary

change the pytorch model type naming when loading the model

Type

Check one that is relevant

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature and improvements (non-breaking change which adds/improves functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Code Refactoring (internal change which is not user facing)
  • Documentation
  • Test, CI, or build

Description

change the pytorch model type naming when loading the model

Jira Link

Link to relevant Jira tickets, stories, epic

Checklist before submitting:

  • Have you followed the general guidelines of GitFlow or GitHub Flow?
  • Have you verified no Secrets/Credentials present in commit ?
  • Have you updated test cases relevants for your code changes?
  • Have you verified all test are passing?
  • Have you verified you code is compliant with best practices?

wattychops
wattychops approved these changes Aug 12, 2024
View reviewed changes
Copy link

@wattychops wattychops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wattychops wattychops merged commit e66ce00 into master Aug 12, 2024
10 checks passed
@wattychops wattychops deleted the tmx-1043 branch August 12, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wattychops wattychops wattychops approved these changes

@stimsoni9 stimsoni9 Awaiting requested review from stimsoni9 stimsoni9 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shumingpeh @wattychops