Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor nested stream calls #156

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mlineen
Copy link

@mlineen mlineen commented Apr 26, 2023

I ran across this method and decided to refactor it. The logic should be the same, but the result will have a different ordering. There's probably a further opportunity to simplify/combine build_erlang_ref?/2 and build_erlang_ref?/3

@ericmj
Copy link
Member

ericmj commented Apr 26, 2023

Nice! That looks way better.

Can you test if it has an impact on performance? Can you also do the same refactor for expected_elixir_tags?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants