Support sub chart dir #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tommy Nguyen <tuannvm@hotmail.com>
|
Thanks for the PR. I think, this needs some more thought. The problem is that this will also detect local chart dependencies which not desireable. I'm not really sure if we should support your use case. Have you tried changing the working directory? Maybe that would work in your case. |
Changing working directory does not fix the issue, as the output of git diff (called here: https://github.com/helm/chart-releaser-action/blob/master/cr.sh#L200) still returns a path from the root of the git repo no matter which subdirectory you're in. This PR handles nested charts_dir nicely: #47 - are there any plans to merge this? |
|
Closing this in favor of #47. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
charts_dir. Let's go through this example:So, the
charts_dirwould beops/helmSigned-off-by: Tommy Nguyen tuannvm@hotmail.com