#889 Only include system.memory on framework #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for silly-valkyrie-e996d9 canceled.
|
|
Hi @thompson-tomo, the client doesn't support framework 4.5. In this case, we can't merge this PR. |
|
sorry, i think i got confused looking at the conditional compilation hence have gone and cleaned up the conditional compilation and simply dropped the dependency all together. |
thompson-tomo
force-pushed
the
chore/#889_OptimiseDependencies
branch
from
50da3ee to
a83dbad
Compare
thompson-tomo
force-pushed
the
chore/#889_OptimiseDependencies
branch
from
a83dbad to
0575762
Compare
thompson-tomo
force-pushed
the
chore/#889_OptimiseDependencies
branch
from
0575762 to
f57b072
Compare
thompson-tomo
force-pushed
the
chore/#889_OptimiseDependencies
branch
2 times, most recently
from
bf8264b to
79ed818
Compare
thompson-tomo
force-pushed
the
chore/#889_OptimiseDependencies
branch
from
79ed818 to
1ec54e9
Compare
thompson-tomo
force-pushed
the
chore/#889_OptimiseDependencies
branch
from
1ec54e9 to
5a60156
Compare
thompson-tomo
force-pushed
the
chore/#889_OptimiseDependencies
branch
from
5a60156 to
2f9a5be
Compare
thompson-tomo
force-pushed
the
chore/#889_OptimiseDependencies
branch
from
2f9a5be to
6aac449
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #889